-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Improve duplicate suggestion #14947
feat(web): Improve duplicate suggestion #14947
Conversation
@alextran1502 do you suggest I implement that change in this PR? |
I think it will help, from looking at the UI, I don't understand right away what "x EXIF" mean |
8b1d3c4
to
565a459
Compare
@alextran1502 I've added the popup as you requested, and also adjusted the algorithm to be more readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
…ggestion' into feat/update-duplicate-suggestion
Head branch was pushed to by a user without write access
@alextran1502 thank you! |
@Sese-Schneider No problem! Thank you |
* feat: Improve duplicate suggestion * format * feat(web): Add deduplication info popup * fix: lint * fmt --------- Co-authored-by: Alex <[email protected]>
* feat: Improve duplicate suggestion * format * feat(web): Add deduplication info popup * fix: lint * fmt --------- Co-authored-by: Alex <[email protected]>
* feat: Improve duplicate suggestion * format * feat(web): Add deduplication info popup * fix: lint * fmt --------- Co-authored-by: Alex <[email protected]>
Description
Improves the algorithm to select the suggested asset on the deduplication page and for mass deduplication.
In addition to the file size, the algorithm now also takes into account the amount of EXIF data present, if multiple assets have the best quality.
In order to make the reasoning of the suggestion more transparent to the user, I also added a info popup to the
DuplicateAsset
view.Screenshots