Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Improve duplicate suggestion #14947

Merged

Conversation

Sese-Schneider
Copy link
Contributor

@Sese-Schneider Sese-Schneider commented Dec 27, 2024

Description

Improves the algorithm to select the suggested asset on the deduplication page and for mass deduplication.

In addition to the file size, the algorithm now also takes into account the amount of EXIF data present, if multiple assets have the best quality.

In order to make the reasoning of the suggestion more transparent to the user, I also added a info popup to the DuplicateAsset view.

Screenshots

@Sese-Schneider Sese-Schneider changed the title feat: Improve duplicate suggestion feat(web): Improve duplicate suggestion Dec 27, 2024
@alextran1502
Copy link
Contributor

I wonder if it would be helpful to explain to the user which criteria are taken into account in mass deduplication by placing them in a popup sheet, which is shown when hovering over an info icon next to this line.

image

@Sese-Schneider
Copy link
Contributor Author

@alextran1502 do you suggest I implement that change in this PR?

@alextran1502
Copy link
Contributor

I think it will help, from looking at the UI, I don't understand right away what "x EXIF" mean

@Sese-Schneider Sese-Schneider force-pushed the feat/update-duplicate-suggestion branch from 8b1d3c4 to 565a459 Compare January 7, 2025 10:48
@Sese-Schneider
Copy link
Contributor Author

@alextran1502 I've added the popup as you requested, and also adjusted the algorithm to be more readable.
Are there any additional steps required from my side? Is it okay to just add string and translation via PR?

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@alextran1502 alextran1502 enabled auto-merge (squash) January 7, 2025 18:08
auto-merge was automatically disabled January 7, 2025 18:19

Head branch was pushed to by a user without write access

@Sese-Schneider
Copy link
Contributor Author

@alextran1502 thank you!
I've fixed some format issues with my latest push, sorry for that...

@alextran1502
Copy link
Contributor

@Sese-Schneider No problem! Thank you

@alextran1502 alextran1502 enabled auto-merge (squash) January 7, 2025 18:22
@alextran1502 alextran1502 merged commit b4c1304 into immich-app:main Jan 7, 2025
33 checks passed
yosit pushed a commit to yosit/immich that referenced this pull request Jan 13, 2025
* feat: Improve duplicate suggestion

* format

* feat(web): Add deduplication info popup

* fix: lint

* fmt

---------

Co-authored-by: Alex <[email protected]>
arctic-foxtato pushed a commit to arctic-foxtato/immich that referenced this pull request Jan 14, 2025
* feat: Improve duplicate suggestion

* format

* feat(web): Add deduplication info popup

* fix: lint

* fmt

---------

Co-authored-by: Alex <[email protected]>
@Sese-Schneider Sese-Schneider deleted the feat/update-duplicate-suggestion branch January 21, 2025 09:11
vladd11 pushed a commit to vladd11/immich that referenced this pull request Jan 25, 2025
* feat: Improve duplicate suggestion

* format

* feat(web): Add deduplication info popup

* fix: lint

* fmt

---------

Co-authored-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants