feat(mobile): query DNS SVCB/HTTPS records #15029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNS Query Service
Resolves the server endpoint and sets the base path for the API client. If DNS resolution fails, it falls back to the original server URL. Logs the resolution process for debugging.
This PR replaces the manual DNS query implementation with the Dart-Basic-Utils library. Key reasons for the change: • Avoids maintaining a custom DNS query logic. • Leverages a reliable third-party library that supports various DNS record types (e.g., SRV). • Simplifies the codebase and improves maintainability.
import dns_query_service.dart; Create DnsQueryService instance; Resolve and set the API endpoint, with SRV record lookup based on domain
|
Hello, Can you please describe how this PR has been tested? The majority of our users use a "normal" public facing domain with a reverse proxy on port 443, how will the SRV implementation affect that? Has it been tested with this standard setup? I see a lot of WARNING and SEVERE logs that seem like they might trigger for people who are not using this relatively niche feature. Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Dart-Basic-Utils for SRV record lookup
This PR replaces the manual DNS query implementation with the Dart-Basic-Utils library.
Key reasons for the change:
• Avoids maintaining a custom DNS query logic.
• Leverages a reliable third-party library that supports various DNS record types (e.g., SRV).
• Simplifies the codebase and improves maintainability.
Closes #14938