bug fix SAML_LOGIN_ENABLED setting logic (getredash#5784)

incentive-me · Feb 17, 2023 · d6dbc64 · d6dbc64
1 parent 82361e7
commit d6dbc64
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/redash/settings/organization.py b/redash/settings/organization.py
@@ -21,7 +21,10 @@
 SAML_SSO_URL = os.environ.get("REDASH_SAML_SSO_URL", "")
 SAML_X509_CERT = os.environ.get("REDASH_SAML_X509_CERT", "")
 SAML_SP_SETTINGS = os.environ.get("REDASH_SAML_SP_SETTINGS", "")
-SAML_LOGIN_ENABLED = SAML_SSO_URL != "" and SAML_METADATA_URL != ""
+if SAML_LOGIN_TYPE == "static":
+    SAML_LOGIN_ENABLED = SAML_SSO_URL != "" and SAML_METADATA_URL != ""
+else:
+    SAML_LOGIN_ENABLED = SAML_METADATA_URL != ""
 
 DATE_FORMAT = os.environ.get("REDASH_DATE_FORMAT", "DD/MM/YY")
 TIME_FORMAT = os.environ.get("REDASH_TIME_FORMAT", "HH:mm")