Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Remove data option from useForm options type #2060

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

pedroborges
Copy link
Collaborator

@pedroborges pedroborges commented Oct 23, 2024

The inclusion of data in VisitOptions can be misleading when using useForm. We should update the type definitions to exclude the data property in this context to prevent confusion.

Closes #2056.

packages/react/src/useForm.ts Outdated Show resolved Hide resolved
packages/vue3/src/useForm.ts Outdated Show resolved Hide resolved
@joetannenbaum
Copy link
Contributor

Thanks, Pedro!

@joetannenbaum joetannenbaum merged commit ba57a60 into master Jan 9, 2025
8 checks passed
@joetannenbaum joetannenbaum deleted the remove-data-option-from-useForm branch January 9, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useForm submit should accept data
2 participants