Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes compilation error if openssl feature is deactivated but rustls activated #4305

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fixes compilation error if openssl feature is deactivated but rustls activated #4305

merged 2 commits into from
Dec 18, 2024

Conversation

TheSamsa
Copy link
Contributor

Fixes: #4304

If openssl default feature is deactivated but rustls is active fluvio does not compile.
It complains about a missing IoError in crates/fluvio/src/config/tls.rs:247

digikata
digikata approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I performed a test build w/ the rustls feature on and default features off and it built great

@digikata digikata changed the title Fixes compilation error if openssl is deactivated but rustls activated Fixes compilation error if openssl feature is deactivated but rustls activated Dec 18, 2024
@digikata digikata added this pull request to the merge queue Dec 18, 2024
Merged via the queue into infinyon:master with commit f3a3d09 Dec 18, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Fluvio without openssl but rustls does not compile
2 participants
@TheSamsa @digikata