Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release files 12 November 2024 #179

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Update release files 12 November 2024 #179

merged 2 commits into from
Nov 13, 2024

Conversation

matentzn
Copy link
Contributor

No description provided.

Copy link
Contributor

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the commits to master since the last release, I expected to see 'has symbol' #167 here, but I don't. Maybe 'annotation-properties' needs to be rebuilt?

I do see #168 and #178, which is good.

@jamesaoverton noticed the template pipeline had not been run before running the release!
@matentzn
Copy link
Contributor Author

Looking through the commits to master since the last release, I expected to see 'has symbol' #167 here, but I don't. Maybe 'annotation-properties' needs to be rebuilt?

Oops yea, forgot to rerun the templates workflow.

@zhengj2007 @jamesaoverton should be ready now!

@jamesaoverton
Copy link
Contributor

Now I see the new terms in the OWL files but not the OBO files. Is that expected?

Copy link
Contributor

@zhengj2007 zhengj2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new annotation property 'has symbol' in OBO format OMO. Need to be updated.

@matentzn
Copy link
Contributor Author

Good we looked at this - few Annotation properties are actually converted into OBO format. Maybe this has to do with the fact that they are not used in the same ontology they are declared?

In any case, I vote to drop OBO support from OMO. I cant imagine anyone using it for anything but as an import into another ontology, which is always done through OWL API so always done through OWL..

I would suggest we merge this here because the problem was always present.

@jamesaoverton
Copy link
Contributor

I would suggest we merge this here because the problem was always present.

Agreed -- the OBO-format releases never had any annotation properties, so no big loss.

@matentzn matentzn merged commit 234a208 into master Nov 13, 2024
1 check passed
@matentzn matentzn deleted the omo-release-121124 branch November 13, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants