Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zuul] Use the stf-crc-jobs project template #122

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

elfiesmelfie
Copy link
Contributor

Instead of updating the .zuul.yaml file everytime
infrawatch/service-telemetry-operator adds a new job, the project-template can be updated in STO, which will propogate the change to the project and avoid leaving gaps in testing.

Depends-On: infrawatch/service-telemetry-operator#514

@elfiesmelfie elfiesmelfie marked this pull request as draft November 6, 2023 18:20
Copy link

This change depends on a change with an invalid configuration.

Instead of updating the .zuul.yaml file everytime
infrawatch/service-telemetry-operator adds a new job, the
project-template can be updated in STO, which will propogate the change
to the project and avoid leaving gaps in testing.

Depends-On: infrawatch/service-telemetry-operator#514
@elfiesmelfie elfiesmelfie force-pushed the efoley-zuul-project_template branch from 3939d73 to 13afa4d Compare November 6, 2023 18:47
Copy link

This change depends on a change with an invalid configuration.

@elfiesmelfie
Copy link
Contributor Author

This change depends on a change with an invalid configuration.

This is expected until https://review.rdoproject.org/r/c/config/+/50707 is merged and the project templates can be used

@leifmadsen
Copy link
Member

recheck

@elfiesmelfie
Copy link
Contributor Author

recheck

Looks like the two expected jobs are running!

@elfiesmelfie elfiesmelfie marked this pull request as ready for review November 7, 2023 19:37
Copy link

This change depends on a change that failed to merge.

Change infrawatch/service-telemetry-operator#514 is needed.

@elfiesmelfie
Copy link
Contributor Author

recheck

@elfiesmelfie
Copy link
Contributor Author

The coveralls job that is failing seems to be a false failure.

The file that is flagged as having lower coverage is https://github.com/infrawatch/sg-core/blob/master/plugins/handler/events/pkg/lib/source.go, which has not been modified recently. The test_source.go file was also not modified recently.
This probably is due to recenet ceilometer enablement, but is unrelated to this patch.

@leifmadsen
Copy link
Member

The coveralls job that is failing seems to be a false failure.

The file that is flagged as having lower coverage is https://github.com/infrawatch/sg-core/blob/master/plugins/handler/events/pkg/lib/source.go, which has not been modified recently. The test_source.go file was also not modified recently. This probably is due to recenet ceilometer enablement, but is unrelated to this patch.

Yea that happens sometimes. I keep looking periodically for a threshold since it's a bit fuzzy, but nothing shows up. You can pretty much just ignore it failing since it's a very small value.

@elfiesmelfie elfiesmelfie merged commit f895c6f into master Nov 16, 2023
14 checks passed
@elfiesmelfie
Copy link
Contributor Author

The failures are not related to this change

@elfiesmelfie elfiesmelfie deleted the efoley-zuul-project_template branch November 16, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants