-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cat-voices): rename SectionsController into SegmentsController #1484
Conversation
❌ Test Report | |
✅ Test Report | |
✅ Test Report | |
...packages/internal/catalyst_voices_blocs/lib/src/proposal_builder/proposal_builder_event.dart
Outdated
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/document_node_id.dart
Outdated
Show resolved
Hide resolved
✅ Test Report | |
✅ Test Report | |
✅ Test Report | |
Description
Just renaming of
SectionsController
intoSegmentsController
and related classes so it aligns with Document semantics.This PR just renames classes, lot's of affected classes but not lot changed that why i wanted to have separate PR so actuall changes are easier to see and read.
NodeId
which is extended byDocumentNodeId
becauseSectionsController
is more general then just DocumentRelated Issue(s)
Part of #1465