Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cat-voices): rename SectionsController into SegmentsController #1484

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

damian-molinski
Copy link
Contributor

Description

Just renaming of SectionsController into SegmentsController and related classes so it aligns with Document semantics.

This PR just renames classes, lot's of affected classes but not lot changed that why i wanted to have separate PR so actuall changes are easier to see and read.

  • Adds abstract NodeId which is extended by DocumentNodeId because SectionsController is more general then just Document

Related Issue(s)

Part of #1465

@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code F14 labels Jan 8, 2025
@damian-molinski damian-molinski self-assigned this Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 377/378}$ | ${\color{red}Fail: 1/378}$ |

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 381/381}$ | ${\color{red}Fail: 0/381}$ |

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@damian-molinski damian-molinski enabled auto-merge (squash) January 9, 2025 10:19
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@damian-molinski damian-molinski merged commit 04c9ece into main Jan 9, 2025
35 checks passed
@damian-molinski damian-molinski deleted the feat/load_proposal_document_1465 branch January 9, 2025 10:35
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code F14 review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants