Merge branch 'main' into chore/SDK-3375/upgrade-next-to-15

inrupt · Jan 6, 2025 · 1208ef1 · 1208ef1
2 parents d607173 + 2b8f3a4
commit 1208ef1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,10 +5,6 @@ within this mono-repo.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## Unreleased
-
-The following changes have been implemented but not released yet:
-
 ## Deprecation notice
 
 - A new signature was introduced for `getSessionFromStorage` in release 2.3.0. The legacy signature is
@@ -30,6 +26,17 @@ const session = await getSessionFromStorage(sessionId, {
 });
 ```
 
+## Unreleased
+
+The following changes have been implemented but not released yet:
+
+### Bugfix
+
+#### browser and node
+
+- Fix the `Session` error listener typing by adding `Error` to the `errorDescription` type so that it reflects the actual behavior.
+  Thanks to @NoelDeMartin for fixing this issue.
+
 ## [2.3.0](https://github.com/inrupt/solid-client-authn-js/releases/tag/v2.3.0) - 2024-11-14
 
 ### Bugfix

diff --git a/packages/core/src/SessionEventListener.ts b/packages/core/src/SessionEventListener.ts
@@ -38,7 +38,10 @@ type SESSION_RESTORED_ARGS = {
 };
 type ERROR_ARGS = {
   eventName: typeof EVENTS.ERROR;
-  listener: (error: string | null, errorDescription?: string | null) => unknown;
+  listener: (
+    error: string | null,
+    errorDescription?: string | Error | null,
+  ) => unknown;
 };
 type SESSION_EXTENDED_ARGS = {
   eventName: typeof EVENTS.SESSION_EXTENDED;