Fix expiration date unit

inrupt · Jan 14, 2025 · fe9012e · fe9012e
1 parent bf16c51
commit fe9012e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/browser/src/login/oidc/ClientRegistrar.ts b/packages/browser/src/login/oidc/ClientRegistrar.ts
@@ -75,8 +75,9 @@ export default class ClientRegistrar implements IClientRegistrar {
     const expirationDate =
       expiresAt !== undefined ? Number.parseInt(expiresAt, 10) : -1;
     // Expiration is only applicable to confidential clients.
+    // Note that Date.now() is in milliseconds, and expirationDate in seconds.
     const expired =
-      storedClientSecret !== undefined && Date.now() > expirationDate;
+      storedClientSecret !== undefined && Math.floor(Date.now() / 1000) > expirationDate;
     if (storedClientId && isKnownClientType(storedClientType) && !expired) {
       return storedClientSecret !== undefined
         ? {
@@ -97,6 +98,7 @@ export default class ClientRegistrar implements IClientRegistrar {
     }
 
     try {
+      console.log(`Registering a new client`);
       const registeredClient = await registerClient(options, issuerConfig);
       // Save info
       const infoToSave: Record<string, string> = {

diff --git a/packages/node/src/login/oidc/ClientRegistrar.ts b/packages/node/src/login/oidc/ClientRegistrar.ts
@@ -110,7 +110,8 @@ export default class ClientRegistrar implements IClientRegistrar {
     const expired =
       storedClientSecret !== undefined &&
       storedClientType === "dynamic" &&
-      Date.now() > expirationDate;
+      // Note that Date.now() is in milliseconds, and expirationDate in seconds.
+      Math.floor(Date.now() / 1000) > expirationDate; 
     if (
       storedClientId !== undefined &&
       isKnownClientType(storedClientType) &&