Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dynamic client expiration #3823

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Jan 7, 2025

Dynamically registered clients eventually expire, after a duration provided by the OpenID Provider at registration time. This change keeps track of the expiration date in the browser code, and performs a now dynamic client registration if the client in use expired.

If a legacy client is present in storage, it will be rotated as if it were expired, to avoid the issue where an expired client is used and results in an error on the OP.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@NSeydoux NSeydoux force-pushed the fix/SDK-3389/client-expiration-browser branch from a4eed87 to 41b43c7 Compare January 8, 2025 10:39
@NSeydoux NSeydoux merged commit 1d718fa into main Jan 15, 2025
32 of 35 checks passed
@NSeydoux NSeydoux deleted the fix/SDK-3389/client-expiration-browser branch January 15, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants