1315 fix failed pipelines

[m7pr]

Close #1315

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      50  53.70%   107-114, 160-169, 171, 183-204, 229-232, 239-245, 248-249, 251
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             189      68  64.02%   24-52, 93, 187, 227-267
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 68       0  100.00%
R/module_nested_tabs.R              220      93  57.73%   40-144, 176, 201-203, 317, 356
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                152      11  92.76%   41-48, 84, 135-136, 174
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 216
R/module_transform_data.R            56      32  42.86%   17-51
R/modules.R                         181      32  82.32%   166-170, 225-228, 326-327, 359-373, 411, 423-431
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 43       0  100.00%
R/teal_data_utils.R                  32       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           203       0  100.00%
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3089    1261  59.18%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6ce76e4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   25 suites   8m 34s ⏱️
253 tests 249 ✅ 4 💤 0 ❌
508 runs  504 ✅ 4 💤 0 ❌

Results for commit 6ce76e4.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
module_teal	💚	$63.64$	$-1.10$	$0$	$0$	$0$	$0$
shinytest2-module_bookmark_manager	💚	$37.55$	$-1.76$	$0$	$0$	$0$	$0$
shinytest2-modules	💚	$40.00$	$-1.21$	$0$	$0$	$0$	$0$
shinytest2-teal_data_module	💔	$47.43$	$+1.16$	$0$	$0$	$0$	$0$

Results for commit 1ca4f1f

♻️ This comment has been updated with latest results.

[m7pr]

https://github.com/insightsengineering/teal/actions/runs/10634055496

[donyunardi]

Thanks for the update, however, the Dependency Test - release and revdepcheck are still failing.

Dependency Test - release

── Dependency resolution (tree): ──

Error : ! Could not solve package dependencies:
* deps::/tmp/RtmpEICD44/filec34faccae5:
  * Can't install dependency teal.data (> 0.6.0.9007) (>= 0.5.1.9009) (>= 0.3.1.9004)
  * Can't install dependency teal.slice (>= 0.5.1.9009) (>= 0.3.1.9004)
  * Can't install dependency teal.reporter (>= 0.3.1.9004)
── Create lockfile... ──────────────────────────────────────────────────────────
Error : ! Could not solve package dependencies:
* deps::/tmp/RtmpEICD44/filec34faccae5:
  * Can't install dependency teal.data (> 0.6.0.9007) (>= 0.5.1.9009) (>= 0.3.1.9004)
  * Can't install dependency teal.slice (>= 0.5.1.9009) (>= 0.3.1.9004)
  * Can't install dependency teal.reporter (>= 0.3.1.9004)

revdepcheck

── INSTALL ─────────────────────────────────────────────────────── 2 versions ──
Installing CRAN version of teal
Installing DEV version of teal
Installing 5 packages: parallelly, listenv, globals, renv, future
Error: Failed to install 'teal' from local:
  (converted from warning) installation of package ‘/tmp/RtmpnwIYxk/filebd5cdc1854/teal_0.15.2.9059.tar.gz’ had non-zero exit status
Execution halted

Need to find out why there are failing.
@pawelru is this something that you can quickly diagnose based on your experience on these workflows?
Personally, I don't understand why Dependency Test - release is failing.

[m7pr]

In here, the release pipeline fails indicating that this package cannot be used using the released version of dependencies.
This is an expected failure

it's quite simple and I believe self explanatory
the release strategy (which uses the released version of deps) must fail if you depend on dev version of any of the dependencies

For the release it is expected that thig might not work when a package depends on a DEV (non-released) version of a package

[m7pr]

revdepcheck might be fixed after changed in revdepcheck in here insightsengineering/setup-r-dependencies#4

[m7pr]

Restared the revdepcheck in here https://github.com/insightsengineering/teal/actions/runs/10666737833

[m7pr]

Still something wrong with revdepcheck that I don't understand

[m7pr]

restarted the check for R-Hub https://github.com/insightsengineering/teal/actions/runs/11162647649

[m7pr]

restarted the check for revdepcheck as well https://github.com/insightsengineering/teal/actions/runs/11162670917

[donyunardi]

Restarted the dependency test:
https://github.com/insightsengineering/teal/actions/runs/11172110749/job/31058038805

As expected, max and released pipeline failed because teal depends on DEV version on some of the dependencies.
Everything else looks good.

[donyunardi]

On second thought, I don't understand why max and released failed. I thought with the implementation of #1361 the workflow will install the dev version of the dependencies?

tagging @m7pr or @pawelru

[pawelru]

The referenced changes are generally speaking for everything except verdepcheck which has its own dependency installation logic (based on well... the VERsions of DEPendencies)

[m7pr]

Yep, those changes are for other builds, not verdepcheck. Let me explain that during today's DAILY