Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module GeoLite Citys. #281

Merged
merged 34 commits into from
Jan 7, 2025
Merged

add module GeoLite Citys. #281

merged 34 commits into from
Jan 7, 2025

Conversation

revrsefr
Copy link
Contributor

@revrsefr revrsefr commented Jan 7, 2025

add module GeoLite Citys to whois response.

revrsefr and others added 29 commits July 3, 2024 11:05
Use RPL_WHOISSPECIAL (320)
This should deal with IS_REMOTE() properly, shared truth all servers on the network with StringExtItem.
New module, add a random ID to xlines.
Use Duration::IsValid(str) for duration validation.
Enahnce for mixedcharacterUTF8 spams.
Changes:
Use of regex to match all emojis.
Block all unicodes.
Notify opers.
Changes:
* Ignore ASCII
* Improuve regex 
* add kiwiirc emoticons.
@SadieCat
Copy link
Member

SadieCat commented Jan 7, 2025

Please only submit changes to one module per pull request and make sure the Git history is clean so I can actually see what has changed.

4/m_censor.cpp Outdated Show resolved Hide resolved
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
@SadieCat
Copy link
Member

SadieCat commented Jan 7, 2025

You probably want to give the module a more descriptive name, e.g. m_whoisgeocity.

4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
Check all Sadie's reviews.
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
4/m_whoisgeolite.cpp Outdated Show resolved Hide resolved
@SadieCat SadieCat merged commit 522a745 into inspircd:master Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants