Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Revert flicker fix #65

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Revert flicker fix #65

wants to merge 36 commits into from

Conversation

shivasku82
Copy link

No description provided.

JeevakaPrabu and others added 30 commits September 18, 2019 11:39
- Image capture in various supported resolutions
- Video recording of 1080p,720p and 480p
- Multicamera capture and recording
- Added clang-format and also coding-style file
- Fixed CtsVerifier Camera Intents failure

Tracked-On: OAM-84763
Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
- Set audio source and profile for video recording with audio
- Remove usage of asserts
- Change the preview based on resolution selection by user
- Changes to address camera and mediarecorder cleanup issues

Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Issues addressed:
- Recorded video quality not matching with the selected resolution
- Preview and recording not working for more than 2 cameras
- Multiple permission requests when multiple cameras are connected
- Captured image orientation not in line with the orientation
- Crash seen on alternate record
- Fix for CTSVerifier test case jump
- Indentation

Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Signed-off-by: Muhammad Aksar <[email protected]>
-Full Screen view for each camera
-Settings screen for each camera
-Limited resolution settings to QVGA, VGA, HD, FHD, 4K
-Thumbnail for both video & picture capture for Quick Preview
-Recording duration countdown while recording video
-UI modifications
-New Activity to handle Camera Intents
-Duration & size info  in file details
-New Multicamera App Icon

Tracked-on: OAM-88628
Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Muhammad Aksar <[email protected]>
Add advance features in MultiCamera app
-Video resolution list based on camera capabilities
-Audio source set to external mic

Tracked-On: OAM-88661
Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Muhammad Aksar <[email protected]>
  -Videos can be recorded for long duration
   depending upon available disk space
  -Camera Preview restricted for 1080p & CIF
   to 720P & VGA respectively
  -Preview aspect Ratio (4:3) 0r (16:9)
   with respect to selected Resolution
  -Few Code clean-up as well
  -Add Exif info for Preview Thumbnail

Tracked-On: OAM-88922
Signed-off-by: Nikumbh, Mayur NimbaX <[email protected]>
Signed-off-by: Muhammad Aksar <[email protected]>
Signed-off-by: Shiva Kumara <[email protected]>
Signed-off-by: Kaushal Billore <[email protected]>
Signed-off-by: Shiva kumara <[email protected]>
Signed-off-by: Kaushal Billore <[email protected]>
Tracked-On : OAM-89663
Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: Kaushal Billore <[email protected]>
Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: Kaushal Billore <[email protected]>
Tracked-On : OAM-90226
Signed-off-by: Shiva Kumara  <[email protected]>
Camera record timer not shown during recording.
When front recording is tried, back camera instance is used
resulting in crash.

Issue fixed by calling showRecordingUI function with correct
camera instance.

Tracked-On : OAM-91223

Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: kbillore <[email protected]>
RootCause- crash is due to trying to unregister receiver
second time in OnPause event

Solution- Register receiver only once in application and
no need of unregister receiver as it will get unregister
automatically on application dies.

Tracked-On : OAM-91356

Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: kbillore <[email protected]>
When application opened and user plug\unplug USB
camera then application start operation on wrong
device id's because when hot plug happends device
id's gets realign because of this many stability
issues observed on USB hot plug

Solution : Whenever USB hot plug detected application
will show dialog to close application. Closing and opening
application will make application works on right device
nodes.

Tracked-On : OAM-91443

Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: kbillore <[email protected]>
When video recording is started with USB headset detected, audio
device doesn't return USB_DEVICE instead it returns USB_HEADSET.
So, preferred audio device is not set resulting in audio not
recorded on video recording.

Fix the issue by setting preferred device for device type
USB_HEADSET.

Tracked-On: OAM-91435
Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Multi camera application receive event for every USB
device plug and unplug. Whenever USB event is detected
application show popup to show application closure.

Solution : Dialog will only when USB camera device is
plug or unplug.

Tracked-On: OAM-91709
Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
For front camera when we try to pass video_list_1, fetching of
video list fails. As a result, video is recorded with resolution 720p.

Solution: Fixed the issue by passing video_list instead of video_list_1.

Tracked-On : OAM-91963

Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
click on settings button in single view is working

Solution: added required implementation to handle settings button
in single view and hide settings button in multiview

Tracked-On : OAM-92012

Signed-off-by: Shiva Kumara  <[email protected]>
Signed-off-by: kbillore <[email protected]>
back camera then record. recorded video is falling
back to default resolution.when switching the camera,
camera close will be called and as part of camera
close it will delete the video key entry.

Solution: not remove the video key entry as part of
camera close. with this only one setting exist for all
camera

Tracked-On: OAM-94317
Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
Because of USB xhci event overflow error sometimes
camera preview configuration is getting failed.

Solution : on receive of stream configuration failure
application will retry preview configuration for 5 times
before it declare failure

Tracked-On: OAM-94318
Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
when user remove one camera then application detects the
hotplug which trigger dialog to user to close application.
When user click on dialog to close app which is calling
activity finish. In next time application launch app is using
cache data for number of camera and it still assume old camera
present and try to access there application crash was observed.

Solution: instead of activity finish we are killing application
process now so next cycle it wont use cache data.

Tracked-On: OAM-94319
Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
change picture resolution and switch camera , after
switching capture.picture is captured in default resolution

Solution: When switch the camera involve closing of camera
which indirectly reset the resolution. now removed the
resetting of resolution.

Tracked-On: OAM-94317
Signed-off-by: Shiva Kumara [email protected]
Signed-off-by: kbillore <[email protected]>
preview was not getting updated when video or capture
resolution settings change.

Solution: triggering preview update on settings close click

Tracked-On: OAM-94317
Signed-off-by: user189 <[email protected]>
on click event of camera settings close was pointing
wrong camera instance.

Solution : corrected to point right camera instance.

Tracked-On: OAM-95529

Signed-off-by: Shiva Kumara <[email protected]>
target sdk version is set to 28

Solution : changed the target sdk version to 30

Tracked-On: OAM-92011
Signed-off-by: Shiva kumara <[email protected]>
When image trying to access in image view crash
occured because with android 11 and targetsdk version 29
or above direct image file access not allowed.

Solution : with android 11 access files directly is not
allowed , used media api to access file uri.

Tracked-On: OAM-96183
Signed-off-by: shiva kumara R <[email protected]>
when switching between camera then sometimes camera
preview started flickering, this flicker is basically
few frames from camera 1 and few frames from camera 2
was rendered

Solution : properly close the current camera and freshly
start new camera

Tracked-On: OAM-96186
Signed-off-by: shiva kumara R <[email protected]>
shivasku82 and others added 6 commits March 17, 2021 10:26
playing video from multi camera app is getting failed
because with android 11 and target sdk version above 29
sharing Uri path to external app is not allowed.

Solution : As work around solution we are changing the vm policy
to allow this application to share URI paths

Tracked-On: OAM-96187
Signed-off-by: shiva kumara R <[email protected]>
image and video capture from multicamra dont have storage
files access to view from other applications.

Solution: added manage storage access permission to
multicamera application to support storage access
permission for android 11.

Tracked-On: OAM-96604
Signed-off-by: shiva kumara R [email protected]
When video gets played it uses player application, once
player activity starts multi camera app goes to background
and multicamera onpause gets called which will release the
camera.

Solution : onResume activity we are reopening camera

Tracked-On: OAM-96604
Signed-off-by: shiva kumara R <[email protected]>
This application is used to monitor Android clipboard,
send clipboard data changes to host side, and set data
which is received from host side to clipboard.

It depends on changes of clipboard service due to Android
11 limitation, and server application in host side.
The communication channel is based on virtio-sock (vsock)
serivce provided by native service.

Execute following command under src folder to generate
native service header file:
javah -classpath ./ -d jni com.intel.penguinpeakutils.VsockClientImpl

Tracked-On: OAM-97756
Signed-off-by: Vinay Prasad Kompella <[email protected]>
Co-authored-by: Zhong, Fangjian <[email protected]>
Currently we do not tolerate connection reset.
This patch enables uninterrupted connection.

Tracked-On: OAM-97785
Signed-off-by: ahs <[email protected]>
Signed-off-by: shivasku82 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants