-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scd] cr deletion now checks for OVN correctness #1083
[scd] cr deletion now checks for OVN correctness #1083
Conversation
@BenjaminPelletier, following our discussion at the last community meeting about maintaining and updating the qualifier configuration used in the CI for the DSS repo, should we maybe change the way we release scenarios that 'break' with the current DSS implementation? So far we have been doing this:
This works, but is a bit ad-hoc and requires trusting the manual step in 2) above. The main reason we do this is that we usually directly update the qualifier configurations when we add a scenario, which means CI runs will necessarily break if the DSS has an open issue. An alternative process could be:
The second process is technically cleaner, albeit a little bit more involved, and introduces the risk to forget to add a relevant configuration to our defaults in step 6). On the other hand, it gets us closer to properly using the qualifier and forces us to go through the gymnastics of properly updating configurations on the DSS side. (Under the current process, we risk forgetting updating the monitoring image or the qualifier configuration on the DSS repo, which is guaranteed to be impossible with the alternative process) I will try the second approach for the set of scenarios that check that OVNs are being verified to see if it is even practical: for entirely new scenarios it should be easy, but for updates to existing scenarios it will be less so. Note that there will still be situations that require an ad-hoc approach. |
197f013
to
eb118ce
Compare
@BenjaminPelletier this is ready for review: if we're interested in moving quickly, the two PRs fixing OVN handling can be merged and a release can be done so we may proceed with the qualifier scenarios interuss/monitoring#761 and interuss/monitoring#762 |
I've added this issue to track that discussion separate from this PR. |
Add a check for the provided OVN before deleting constraint references.
Once #1082 is merged, this will close #1081
Test plan: a DSS built from this PR was used as a target for this scenario and behaved properly.