fix(ios, app): macOS 12.3 removed python, use python3 #6234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
macOS 12.3 (released March 24, about a month ago) removed the python2 installation (binary of
python
)Our ios config script depended on that binary existing and silently failed / false-positived if it did not exist, with symptom being that on ios the config used all default values.
I do a check for python3 existence now and forward-ported the python2 code to python3 so our firebase.json parsing works again. Likely needs the same thing for react-native-google-mobile-ads...
This was only visible on macOS 12.3 machines running our e2e harness (where this functionality is probed) or by eagle-eyed developers who noticed the problem. A related change will move CI to macos-12 runners (just now available!) to make sure it fails on them, then I'll rebase against this to make sure it works...
Related issues
Fixes #6226
Fixes #6203
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter