Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, app): macOS 12.3 removed python, use python3 #6234

Merged
merged 1 commit into from
May 10, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

macOS 12.3 (released March 24, about a month ago) removed the python2 installation (binary of python)
Our ios config script depended on that binary existing and silently failed / false-positived if it did not exist, with symptom being that on ios the config used all default values.

I do a check for python3 existence now and forward-ported the python2 code to python3 so our firebase.json parsing works again. Likely needs the same thing for react-native-google-mobile-ads...

This was only visible on macOS 12.3 machines running our e2e harness (where this functionality is probed) or by eagle-eyed developers who noticed the problem. A related change will move CI to macos-12 runners (just now available!) to make sure it fails on them, then I'll rebase against this to make sure it works...

Related issues

Fixes #6226
Fixes #6203

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview May 10, 2022 at 4:23AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) May 10, 2022 at 4:23AM (UTC)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #6234 (593de24) into main (f26482d) will not change coverage.
The diff coverage is n/a.

❗ Current head 593de24 differs from pull request most recent head 258b267. Consider uploading reports for the commit 258b267 to get more accurate results

@@            Coverage Diff            @@
##               main    #6234   +/-   ##
=========================================
  Coverage     53.40%   53.40%           
  Complexity      643      643           
=========================================
  Files           208      208           
  Lines         10302    10302           
  Branches       1633     1633           
=========================================
  Hits           5501     5501           
  Misses         4543     4543           
  Partials        258      258           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant