Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analytics): note possible problems with event parameters #8243

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

mikehardy
Copy link
Collaborator

Description

Event parameters must be correct to generate events in google analytics, but validation is problematic so is basically not performed at any layer, resulting in silent failure

This documents that and warns developers to be careful

Came up in discussion on an issue and documentation appears to be the best solution

Also fixed one bit of invalid markdown in use in dynamic-links, unrelated really but related in that I was trying to generate a warning box there the same way as I was here. It showed up as an example but was wrong.

Related issues

Fixes

Release Summary

semantic release compatible commits will auto-generate changelog

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Looked at markdown preview in vscode to make sure markdown was correct
ran spellcheck and fixed up little error there

ran general text by original poster, seems okay


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:32pm

@mikehardy mikehardy added plugin: analytics Google Analytics for Firebase Workflow: Pending Merge Waiting on CI or similar labels Jan 22, 2025
github markdown syntax doesn't work in the more general markdown tooling
the docs site renders with
@mikehardy mikehardy force-pushed the @mikehardy/analytics-log-event-params-warning branch from 47b6742 to 0daa522 Compare January 22, 2025 17:25
@mikehardy
Copy link
Collaborator Author

Looks +1 on check of Vercel preview

@mikehardy mikehardy merged commit 87b9e8d into main Jan 22, 2025
10 of 11 checks passed
@mikehardy mikehardy deleted the @mikehardy/analytics-log-event-params-warning branch January 22, 2025 17:31
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention plugin: analytics Google Analytics for Firebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant