docs(analytics): note possible problems with event parameters #8243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event parameters must be correct to generate events in google analytics, but validation is problematic so is basically not performed at any layer, resulting in silent failure
This documents that and warns developers to be careful
Came up in discussion on an issue and documentation appears to be the best solution
Also fixed one bit of invalid markdown in use in dynamic-links, unrelated really but related in that I was trying to generate a warning box there the same way as I was here. It showed up as an example but was wrong.
Related issues
Fixes
Release Summary
semantic release compatible commits will auto-generate changelog
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Looked at markdown preview in vscode to make sure markdown was correct
ran spellcheck and fixed up little error there
ran general text by original poster, seems okay
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter