feat(select): add helperText and errorText properties #30143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
brandyscarney
commented
Jan 22, 2025
Comment on lines
+1031
to
+1036
| <div id={helperTextId} class="helper-text" part="supporting-text helper-text"> | ||
| {helperText} | ||
| </div>, | ||
| <div id={errorTextId} class="error-text" part="supporting-text error-text"> | ||
| {errorText} | ||
| </div>, |
There was a problem hiding this comment.
I added the supporting-text part so users could change them at the same time using:
ion-select::part(supporting-text) {
font-size: 20px;
}but if we think it should only be the one part they could write this without it:
ion-select::part(helper-text),
ion-select::part(error-text) {
font-size: 20px;
}I am copying Material Design 2 and Material Design 3 naming here, but let me know if there are other ideas.
brandyscarney
requested review from
thetaPC
and removed request for
JoaoFerreira-FrontEnd
thetaPC
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Would it be beneficial to update @prop --highlight-color-invalid definition to also mention that it will also change error text?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29205
What is the current behavior?
Select does not support helper and error text.
What is the new behavior?
helperTextanderrorTexthelper-text,error-textandsupporting-textDoes this introduce a breaking change?
Other information
Preview
Co-authored-by: swimer11 [email protected]