-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toggle): add required prop #30156
Open
OS-giulianasilva
wants to merge
14
commits into
feature-8.5
Choose a base branch
from
ROU-11112-toggle
base: feature-8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pozil/auto-assign-issue](https://redirect.github.com/pozil/auto-assign-issue) | action | patch | `v2.1.1` -> `v2.1.2` | --- ### Release Notes <details> <summary>pozil/auto-assign-issue (pozil/auto-assign-issue)</summary> ### [`v2.1.2`](https://redirect.github.com/pozil/auto-assign-issue/releases/tag/v2.1.2): - Fix failsIfUsersCannotBeAssigned flag support [Compare Source](https://redirect.github.com/pozil/auto-assign-issue/compare/v2.1.1...v2.1.2) - fix: failsIfUsersCannotBeAssigned flag support and improves error handling </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chalk](https://redirect.github.com/chalk/chalk) | [`5.4.0` -> `5.4.1`](https://renovatebot.com/diffs/npm/chalk/5.4.0/5.4.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chalk/5.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chalk/5.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chalk/5.4.0/5.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chalk/5.4.0/5.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chalk/chalk (chalk)</summary> ### [`v5.4.1`](https://redirect.github.com/chalk/chalk/releases/tag/v5.4.1) [Compare Source](https://redirect.github.com/chalk/chalk/compare/v5.4.0...v5.4.1) - Fix `navigator` not defined `ReferenceError` ([#​642](https://redirect.github.com/chalk/chalk/issues/642)) [`4ebb62d`](https://redirect.github.com/chalk/chalk/commit/4ebb62d) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@clack/prompts](https://redirect.github.com/natemoo-re/clack/tree/main/packages/prompts#readme) ([source](https://redirect.github.com/natemoo-re/clack/tree/HEAD/packages/prompts)) | [`0.9.0` -> `0.9.1`](https://renovatebot.com/diffs/npm/@clack%2fprompts/0.9.0/0.9.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@clack%2fprompts/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@clack%2fprompts/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@clack%2fprompts/0.9.0/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@clack%2fprompts/0.9.0/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>natemoo-re/clack (@​clack/prompts)</summary> ### [`v0.9.1`](https://redirect.github.com/natemoo-re/clack/blob/HEAD/packages/prompts/CHANGELOG.md#091) [Compare Source](https://redirect.github.com/natemoo-re/clack/compare/@clack/[email protected]...@clack/[email protected]) ##### Patch Changes - [`8093f3c`](https://redirect.github.com/natemoo-re/clack/commit/8093f3c): Adds `Error` support to the `validate` function - [`98925e3`](https://redirect.github.com/natemoo-re/clack/commit/98925e3): Exports the `Option` type and improves JSDocannotations - [`1904e57`](https://redirect.github.com/natemoo-re/clack/commit/1904e57): Replace custom utility for stripping ANSI control sequences with Node's built-in [`stripVTControlCharacters`](https://nodejs.org/docs/latest/api/util.html#utilstripvtcontrolcharactersstr) utility. - Updated dependencies \[[`8093f3c`](https://redirect.github.com/natemoo-re/clack/commit/8093f3c)] - Updated dependencies \[[`e5ba09a`](https://redirect.github.com/natemoo-re/clack/commit/e5ba09a)] - Updated dependencies \[[`8cba8e3`](https://redirect.github.com/natemoo-re/clack/commit/8cba8e3)] - [@​clack/core](https://redirect.github.com/clack/core)[@​0](https://redirect.github.com/0).4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil/angular-output-target](https://stenciljs.com/) ([source](https://redirect.github.com/ionic-team/stencil-ds-output-targets)) | [`^0.8.4` -> `^0.10.0`](https://renovatebot.com/diffs/npm/@stencil%2fangular-output-target/0.8.4/0.10.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fangular-output-target/0.10.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fangular-output-target/0.10.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fangular-output-target/0.8.4/0.10.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fangular-output-target/0.8.4/0.10.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@stencil/vue-output-target](https://stenciljs.com/) ([source](https://redirect.github.com/ionic-team/stencil-ds-output-targets)) | [`^0.8.9` -> `^0.9.0`](https://renovatebot.com/diffs/npm/@stencil%2fvue-output-target/0.8.9/0.9.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fvue-output-target/0.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fvue-output-target/0.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fvue-output-target/0.8.9/0.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fvue-output-target/0.8.9/0.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/stencil-ds-output-targets (@​stencil/angular-output-target)</summary> ### [`v0.10.2`](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) [Compare Source](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) ### [`v0.10.1`](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) [Compare Source](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) ### [`v0.10.0`](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) [Compare Source](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) ### [`v0.9.1`](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/angular-output-target@0.9.0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) [Compare Source](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/angular-output-target@0.9.0...a3588e905186a0e86e7f88418fd5b2f9531b55e0) ### [`v0.9.0`](https://redirect.github.com/ionic-team/stencil-ds-output-targets/releases/tag/%40stencil/angular-output-target%400.9.0) [Compare Source](https://redirect.github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/[email protected]...@stencil/[email protected]) #### What's Changed - feat(angular): Standalone Value Accessor for Angular OutputType by [@​Samg983](https://redirect.github.com/Samg983) in [https://github.com/ionic-team/stencil-ds-output-targets/pull/459](https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/459) #### New Contributors - [@​Samg983](https://redirect.github.com/Samg983) made their first contribution in [https://github.com/ionic-team/stencil-ds-output-targets/pull/459](https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/459) **Full Changelog**: https://github.com/ionic-team/stencil-ds-output-targets/compare/[@​stencil/react-output-target](https://redirect.github.com/stencil/react-output-target)[@​0](https://redirect.github.com/0).7.0...[@​stencil/angular-output-target](https://redirect.github.com/stencil/angular-output-target)[@​0](https://redirect.github.com/0).9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-actions
bot
added
package: core
@ionic/core package
package: angular
@ionic/angular package
package: vue
@ionic/vue package
labels
Jan 24, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: react
@ionic/react package
package: vue
@ionic/vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
required={true}
.What is the new behavior?
required
prop to be used for accessibility purposes that adds therequired
attribute to toggle's inner native input.Does this introduce a breaking change?