Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-dashboard): hook collect(unwrap) feature to dashboard #1502

Merged
merged 59 commits into from
Aug 27, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jul 30, 2024

Description of change

Hook collect(unwrap) feature to dashboard

Links to any relevant issues

Closes #1087

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

cpl121 and others added 18 commits July 18, 2024 18:40
…tfolio' into tooling-dashboard/add-a-vesting-page
…tfolio' into tooling-dashboard/add-a-vesting-page
…shboard/fetch-supply-increases-timelocked-portfolio' of github.com:iotaledger/kinesis into tooling-dashboard/add-a-vesting-page
…tfolio' into tooling-dashboard/add-a-vesting-page
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8d22b5b

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-c4zq5j2g6.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fe13bd1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-lt0401985.vercel.app

Base automatically changed from tooling-dashboard/add-a-vesting-page to develop July 31, 2024 16:36
@marc2332 marc2332 added the tooling Issues related to the Tooling team label Aug 1, 2024
… of github.com:iotaledger/kinesis into tooling-dashboard/hook-collect-feature
Copy link
Contributor

github-actions bot commented Aug 2, 2024

This pull request has been deployed to Vercel.

Latest commit: 17d0195

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-7eoum7to0.vercel.app

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 5b01bd4

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-le5e9sakb.vercel.app

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 6752846

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-uvvb9i98l.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG just a small improvement

apps/wallet-dashboard/app/dashboard/vesting/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0a8c2f8

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-oj7sqnkam.vercel.app

@cpl121 cpl121 requested a review from brancoder August 26, 2024 12:27
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9b1f9c9

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jyrrt5fys.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d84b2ec

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ohonsl5dj.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0db4a9f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hgwbte1vm.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 16ec8ff

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-8t75nipgj.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI is failing 🙏
name changes to ExtendedDelegatedTimelockedStake is causing vesting.spec tests to fail

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e40a80d

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-5y6xwlmwa.vercel.app

@cpl121 cpl121 requested a review from brancoder August 27, 2024 07:40
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5dba641

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-joqi86k4a.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brancoder brancoder dismissed marc2332’s stale review August 27, 2024 08:08

All comments are resolved

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a85e580

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jwitytojr.vercel.app

@brancoder brancoder merged commit d4cc7d4 into develop Aug 27, 2024
24 checks passed
@brancoder brancoder deleted the tooling-dashboard/hook-collect-feature branch August 27, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet-dashboard)]: Hook collect(unwrap) feature to dashboard
4 participants