Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): rebrand new mnemonic success page #1533

Merged
merged 23 commits into from
Aug 14, 2024
Merged

feat(wallet): rebrand new mnemonic success page #1533

merged 23 commits into from
Aug 14, 2024

Conversation

panteleymonchuk
Copy link
Contributor

@panteleymonchuk panteleymonchuk commented Jul 31, 2024 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes #1465
Depends on #1550 because we have updated checkbox.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk
feat(wallet): BackupMnemonicPage rebrand.
1a32c75 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk added the tooling Issues related to the Tooling team label Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1a32c75

✅ Preview: https://apps-ui-omncyt0wm-iota1.vercel.app

@panteleymonchuk panteleymonchuk marked this pull request as ready for review July 31, 2024 16:10
@panteleymonchuk panteleymonchuk requested review from a team as code owners July 31, 2024 16:10
evavirseda
evavirseda requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, just two details 🙏

apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

This pull request has been deployed to Vercel.

Latest commit: 5d64ff8

✅ Preview: https://apps-ui-jqgea44gs-iota1.vercel.app

@begonaalvarezd begonaalvarezd changed the title feat(wallet): BackupMnemonicPage rebrand. feat(wallet): rebrand backup mnemonic page Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 8cfb1c2

✅ Preview: https://apps-ui-pvorapknm-iota1.vercel.app

@panteleymonchuk
feat(wallet): Onboarding. New wallet success & backup page updates.
83617df 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
feat(wallet): Onboarding. New wallet success & backup page updates. pt2.
b67b14b 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Merge remote-tracking branch 'iotaledger/develop' into tooling-wallet…
9c22f49 
…/rebrand-create-mnemonic

# Conflicts:
#	apps/ui-kit/src/lib/components/molecules/input/InputTrailingElement.tsx
@panteleymonchuk
feat(wallet): Onboarding. New wallet success & backup page updates. F…
58d7cf6 
…ix after merge.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
evavirseda
evavirseda requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, some comments 🙏

apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d204525

✅ Preview: https://apps-ui-gdr45qm55-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9c684ba

✅ Preview: https://apps-ui-spntbh8s2-iota1.vercel.app

evavirseda
evavirseda requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one detail I had missed 🙏 and we’re ready to go!

apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/BackupMnemonicPage.tsx Show resolved Hide resolved
@begonaalvarezd begonaalvarezd changed the title feat(wallet): rebrand backup mnemonic page feat(wallet): rebrand new mnemonic success page Aug 12, 2024
begonaalvarezd
begonaalvarezd requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀
I just noted some improvements we can make on this page, I opened a PR to showcase these improvements #1755

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 09c4019

✅ Preview: https://apps-ui-96aravg8z-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 816d0e0

✅ Preview: https://apps-ui-dksvmtdnq-iota1.vercel.app

panteleymonchuk and others added 2 commits August 14, 2024 11:01
@panteleymonchuk
Merge remote-tracking branch 'iotaledger/develop' into tooling-wallet…
d9cb1c7 
…/rebrand-create-mnemonic

# Conflicts:
#	apps/ui-kit/src/lib/components/molecules/input/TextArea.tsx
@evavirseda
Merge branch 'develop' into tooling-wallet/rebrand-create-mnemonic
c493196
evavirseda
evavirseda approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🧑‍🎨 🖌️ 🎨

@begonaalvarezd begonaalvarezd merged commit 5a56ab9 into develop Aug 14, 2024
23 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/rebrand-create-mnemonic branch August 14, 2024 15:53
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
@panteleymonchuk @begonaalvarezd
@evavirseda @bingyanglin
feat(wallet): rebrand new mnemonic success page (#1533)
7404e77 
* feat(wallet): BackupMnemonicPage rebrand.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): BackupMnemonicPage rebrand. Remove debris.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): Onboarding. New wallet success & backup page updates.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): Onboarding. New wallet success & backup page updates. pt2.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): Onboarding. New wallet success & backup page updates. Fix after merge.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): update ui and add copy button on BackupMnemonicPage

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* feat(wallet): cover copy button my condition. BackupMnemonicPage.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

* refactor: mnemonic success page

* feat: hide copy button if mnemonic is encrypted

* fix: pushed test data

---------

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Co-authored-by: Begoña Alvarez <[email protected]>
Co-authored-by: evavirseda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@panteleymonchuk panteleymonchuk

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet)]: Rebrand Onboarding: Apply new theme to mnemonic success page
3 participants
@panteleymonchuk @begonaalvarezd @evavirseda