-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-keys): Support the Shimmer coin type for the derivation path validation #1742
feat(iota-keys): Support the Shimmer coin type for the derivation path validation #1742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output looks like this
╭─────────────────┬──────────────────────────────────────────────────────────────────────────────────────╮
│ alias │ │
│ iotaAddress │ 0xc17acc2e56d94ae8331205baf5cdb727f036abd787f295f00739cfa45920ff7d │
│ publicBase64Key │ ANBMoej0dIKGh36kkcRIbPmWARUc81WugEJkT7ZO3+W1 │
│ keyScheme │ ed25519 │
│ flag │ 0 │
│ mnemonic │ connect clutch cool raccoon grass plunge filter fitness three vibrant office occur │
│ peerId │ d04ca1e8f4748286877ea491c4486cf99601151cf355ae8042644fb64edfe5b5 │
╰─────────────────┴──────────────────────────────────────────────────────────────────────────────────────╯
Do you think it could be confusing that it never mentions the coin type?
Shall we open an issue for it? |
I've opened #1744, let's reassess later, not extremely important. |
…h validation (#1742) * feat(iota-keys): support Shimmer coin type for derivation path validation * fix(iota-keys): comment
…h validation (#1742) * feat(iota-keys): support Shimmer coin type for derivation path validation * fix(iota-keys): comment
Description of change
This PR simply allows a derivation path containing the Shimmer coin type (4219) to be validated during the keypair creation process in the Rust SDK.
Links to any relevant issues
Related to #1047
Type of change
How the change has been tested
cargo run --bin iota keytool generate ed25519 "m/44'/4219'/0'/0'/0'"
Change checklist