Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix cli keytool and move references #1760

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Fix CLI keytool and move references where they were outdated

Links to any relevant issues

#1613

Type of change

  • Documentation Fix

How the change has been tested

Running the CLI commands and compared the results

@Thoralf-M Thoralf-M requested a review from a team as a code owner August 13, 2024 08:12
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Thoralf-M Thoralf-M added the dev-tools Issues related to the Developer Tools Team label Aug 13, 2024
Copy link
Contributor

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, although technically it works :trollface:

docs/content/references/cli/move.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Thoralf-M Thoralf-M force-pushed the dev-tools/cli-keytool-move-references branch from 53b93ff to 04fcbae Compare August 13, 2024 18:00
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add help info for the move CLI build and disassemble? It's okay if this is in a new PR tho

@Thoralf-M
Copy link
Member Author

@DaughterOfMars should be done as part of #1060

@Thoralf-M Thoralf-M merged commit 9ffa886 into develop Aug 19, 2024
24 checks passed
@Thoralf-M Thoralf-M deleted the dev-tools/cli-keytool-move-references branch August 19, 2024 07:34
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
* fix(docs): fix cli keytool and move references

* Update docs/content/references/cli/move.mdx

Co-authored-by: Dr-Electron <[email protected]>

* Multiline indented

---------

Co-authored-by: Dr-Electron <[email protected]>
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
* fix(docs): fix cli keytool and move references

* Update docs/content/references/cli/move.mdx

Co-authored-by: Dr-Electron <[email protected]>

* Multiline indented

---------

Co-authored-by: Dr-Electron <[email protected]>
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
* fix(docs): fix cli keytool and move references

* Update docs/content/references/cli/move.mdx

Co-authored-by: Dr-Electron <[email protected]>

* Multiline indented

---------

Co-authored-by: Dr-Electron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants