Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): gas-in-iota.mdx was corrected #1769

Merged

Conversation

valeriyr
Copy link
Contributor

Description of change

gas-in-iota.mdx was checked and corrected according to the current IOTA gas model.

  1. The bucketing model was changed to use the step/rounding approach.
  2. The document parts were checked for correctness.

Links to any relevant issues

fixes #1547

@valeriyr valeriyr added the vm-language Issues related to the VM & Language Team label Aug 13, 2024
@valeriyr valeriyr self-assigned this Aug 13, 2024
@valeriyr valeriyr requested a review from a team as a code owner August 13, 2024 09:49
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@miker83z miker83z linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a suggestion:

docs/content/about-iota/tokenomics/gas-in-iota.mdx Outdated Show resolved Hide resolved
docs/content/about-iota/tokenomics/gas-in-iota.mdx Outdated Show resolved Hide resolved
@valeriyr valeriyr force-pushed the vm-language/feat/issue-1547-gas-in-iota-proofreading branch from a56171d to 8a24e0f Compare August 13, 2024 15:45
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@valeriyr valeriyr merged commit 72bb2cd into docs/tokenomics Aug 14, 2024
34 of 36 checks passed
@valeriyr valeriyr deleted the vm-language/feat/issue-1547-gas-in-iota-proofreading branch August 14, 2024 10:57
lzpap added a commit that referenced this pull request Aug 27, 2024
* New diagram and reviews

* Some typos and higher resolution diagram

* update economic model

* Validator Requirement

* Update docs/content/about-iota/tokenomics/proof-of-stake.mdx

Co-authored-by: Philipp Gackstatter <[email protected]>

* Update docs/content/about-iota/tokenomics/proof-of-stake.mdx

Co-authored-by: Philipp Gackstatter <[email protected]>

* addressing comments

* Philipp review suggestions

* Update validator pool rewards description

* remove unrelated pdfs

* add fee burning to explanation

* remove info about distribution of fees

* rephrase tallying rule (from total slashing to possibly a partial slashing)

* remove mention of gas fees

* feat(docs): gas-in-iota.mdx was corrected (#1769)

* feat(docs): gas-in-iota.mdx was corrected

* fix(docs): review comments were corrected

* fix(docs): review comments were fixed

* Fix Rewards Formula

* gas budget formula fix

* Update docs/content/about-iota/tokenomics/iota-token.mdx

Co-authored-by: Levente Pap <[email protected]>

* fix(docs): wrong md link

---------

Co-authored-by: oliviasaa <[email protected]>
Co-authored-by: Luigi Vigneri <[email protected]>
Co-authored-by: Philipp Gackstatter <[email protected]>
Co-authored-by: Valerii Reutov <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Levente Pap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm-language Issues related to the VM & Language Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (Docs)]: Proof-read Gas in IOTA under About IOTA
6 participants