feat!(iota): disable zklogin in keytool #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing to remove from reference/documentation? |
@thibault-martinez no, there it was already removed in #1200 |
thibault-martinez
approved these changes
Aug 13, 2024
DaughterOfMars
approved these changes
Aug 13, 2024
8 tasks
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
* feat!(iota): disable zklogin in keytool * Link issue in comment
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* feat!(iota): disable zklogin in keytool * Link issue in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Disable zklogin functions in they keytool as we don't want to have this functionality (at least for now)
Links to any relevant issues
#189
Type of change
How the change has been tested
cargo check && cargo test