fix(iota-genesis-builder): test outputs SDRUC amounts #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miker83z
added
the
sc-platform
miker83z
changed the title
Thoralf-M
approved these changes
Aug 14, 2024
thibault-martinez
approved these changes
Aug 14, 2024
|
@lzpap This change means that the test outputs objects snapshot should be regenerated and uploaded to S3 (maybe also adding the new Shimmer snapshot). |
miker83z
merged commit 234622f
into
sc-platform/shimmer-test-outputs
15 of 17 checks passed
kodemartin
pushed a commit
that referenced
this pull request
Aug 14, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There was an extra zero in all basic outputs with SDRUC, making them impossible to unlock!