Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iota-sdk): align examples #1877

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Aug 16, 2024

Description of change

Moved the examples description to the top and added missing ones. Also added the cargo run command, so it's easier to run them.
Also had to increase the gas values, as the txs were failing because of insufficient gas.

Links to any relevant issues

#1613

Type of change

  • Documentation Fix

How the change has been tested

Running them

@Thoralf-M Thoralf-M requested a review from a team as a code owner August 16, 2024 08:50
@Thoralf-M Thoralf-M added the dev-tools Issues related to the Developer Tools Team label Aug 16, 2024
@Thoralf-M Thoralf-M changed the title refactor(iota-sdk): Align examples refactor(iota-sdk): align examples Aug 16, 2024
@DaughterOfMars
Copy link
Contributor

Also added the cargo run command, so it's easier to run them.

Is this in another PR?

@thibault-martinez
Copy link
Member

Also added the cargo run command, so it's easier to run them.

Is this in another PR?

I see them in this PR?

@Thoralf-M
Copy link
Member Author

@DaughterOfMars no, I mean this in the examples //! cargo run --example coin_read_api

@Thoralf-M Thoralf-M merged commit f799853 into develop Aug 19, 2024
32 of 34 checks passed
@Thoralf-M Thoralf-M deleted the dev-tools/iota-sdk-examples branch August 19, 2024 14:13
alexsporn pushed a commit that referenced this pull request Sep 6, 2024
* refactor(iota-sdk): Align examples

* Highlight the cargo command with a new line

* Empty commit to trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants