Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooling-general): Remove IOTA Name Service #1966

Merged
merged 11 commits into from
Sep 17, 2024
Merged

refactor(tooling-general): Remove IOTA Name Service #1966

merged 11 commits into from
Sep 17, 2024

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Aug 21, 2024 •
edited
Loading

Closes #1611

@marc2332 marc2332 added the tooling Issues related to the Tooling team label Aug 21, 2024
@marc2332 marc2332 self-assigned this Aug 21, 2024
@marc2332 marc2332 changed the title refactor(general): Remove IOTA Name Service refactor(tooling-general): Remove IOTA Name Service Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 077b03e

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-khijjnls5.vercel.app

@thibault-martinez
Copy link
Member

Should the PR be to update-rpc as well?

@marc2332
Copy link
Contributor Author

Should the PR be to update-rpc as well?

mmm, good point, I guess so

@begonaalvarezd begonaalvarezd mentioned this pull request Sep 6, 2024
Merged
@marc2332 marc2332 force-pushed the tooling-general/remove-iotans branch from cbde2b1 to 5056051 Compare September 13, 2024 15:30
@marc2332 marc2332 force-pushed the tooling-general/remove-iotans branch from 8b19863 to 9dcf721 Compare September 13, 2024 16:13
@marc2332 marc2332 force-pushed the tooling-general/remove-iotans branch from 9dcf721 to 1d9e975 Compare September 13, 2024 16:22
@marc2332 marc2332 marked this pull request as ready for review September 16, 2024 07:33
@marc2332 marc2332 requested review from a team as code owners September 16, 2024 07:33
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1d9e975

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-polxo9cz8.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

begonaalvarezd
begonaalvarezd requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous comments still need addressing

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5c7eb65

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-93cjx5bmn.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7260201

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-pdu6hjuiy.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@begonaalvarezd begonaalvarezd merged commit a3c1937 into develop Sep 17, 2024
16 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-general/remove-iotans branch September 17, 2024 11:19
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 996e818

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-c8jkgxqmn.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Ginowine Ginowine Ginowine approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@marc2332 marc2332

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (tooling)]: Remove IOTA Name Service
6 participants
@marc2332 @thibault-martinez @begonaalvarezd @Ginowine @samuel-rufi @salaheldinsoliman