Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iota-indexer: Add tests for TransactionBuilder api #3753

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Oct 29, 2024

Description of change

Add tests for TransactionBuilder api.

The test for publish is omitted since it's tested as part of other tests.

Stake related methods (request_add_stake, request_withdraw_stake, request_add_timelocked_stake, request_withdraw_timelocked_stake) will be fully covered in a different PR, in scope of #3811

Links to any relevant issues

#2202

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

cargo test --profile simulator --features shared_test_runtime --test rpc-tests transaction_builder

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@tomxey tomxey self-assigned this Oct 29, 2024
@alexsporn alexsporn added the infrastructure Issues related to the Infrastructure Team label Oct 29, 2024
@tomxey tomxey force-pushed the sc-platform/add-transaction-builder-api-tests-for-indexer branch 3 times, most recently from 8d74379 to 75b192c Compare October 30, 2024 16:11
@tomxey tomxey force-pushed the sc-platform/add-transaction-builder-api-tests-for-indexer branch from 75b192c to 9b4a9c4 Compare October 30, 2024 16:13
@tomxey tomxey marked this pull request as ready for review October 30, 2024 16:14
@tomxey tomxey requested a review from a team as a code owner October 30, 2024 16:14
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9b4a9c4

✅ Preview: https://apps-ui-r91ws4m1e-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9b4a9c4

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1pvtep4dv.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9b4a9c4

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qo50i22hp.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9b4a9c4

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1p2gaghv6.vercel.app

Copy link
Member

@samuel-rufi samuel-rufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @tomxey !

Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!! 🌟

@tomxey tomxey merged commit 211686f into sc-platform/indexer-new-rpc-tests Oct 31, 2024
60 of 71 checks passed
@tomxey tomxey deleted the sc-platform/add-transaction-builder-api-tests-for-indexer branch October 31, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants