Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove(docker): remove unused images #4803

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Jan 15, 2025

Description of change

I want to cleanup the docker repository. First step is to remove the unused images.

  • deterministic-canary: we don't use the deterministic builds. if someone needs that, they should create it themselves.
  • iota-node-deterministic: we don't use the deterministic builds. if someone needs that, they should create it themselves.
  • iota-indexer-tidb: mysql feature will be removed soon. not needed anymore.
  • iota-rosetta-devnet: This dockerfile git clones "devnet" branch inside the dockerfile, which is not a deterministic workflow.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners January 15, 2025 16:38
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:35pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:35pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 3:35pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 3:35pm

@muXxer muXxer merged commit 19a37e5 into develop Jan 17, 2025
39 checks passed
@muXxer muXxer deleted the node/cleanup-docker-setups branch January 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants