Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Fix one more possible crash in execution_driver #4900

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bingyanglin
Copy link
Contributor

Description of change

Don't even try to execute certs from prior epochs, from [cherrypick] Fix one more possible crash in execution_driver (#19870)

Links to any relevant issues

fixes #4673

Type of change

  • Bug fix

How the change has been tested

Ran the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Jan 19, 2025
@bingyanglin bingyanglin self-assigned this Jan 19, 2025
Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2025 7:43am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2025 7:43am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Jan 19, 2025 7:43am
apps-ui-kit ⬜️ Ignored (Inspect) Jan 19, 2025 7:43am

@bingyanglin bingyanglin marked this pull request as ready for review January 20, 2025 03:45
@bingyanglin bingyanglin requested review from a team as code owners January 20, 2025 03:45
@muXxer
Copy link
Contributor

muXxer commented Jan 20, 2025

I think it breaks the verify_latest_tx_replay_testnet_mainnet test. Did they change that test on their side, or what is the difference?

Edit: It seems to be broken in the other PR as well. Is that a problem on current develop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cherrypick] Fix one more possible crash in execution_driver (#19870) · MystenLabs/sui@7a166ee
5 participants