Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remote/pinning): Ls to take results channel instead of returning one #738

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

gammazero
Copy link
Contributor

This PR creates a new client Ls API that takes a write-only results channel instead of returns one. This is needed by ipfs/kubo#10527

The original Ls behavior is implemented by the GoLs function, which creates the channels, starts the goroutine that calls Ls, and returns the channels to the caller.

@gammazero gammazero requested a review from a team as a code owner December 3, 2024 09:55
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 60.44%. Comparing base (984fa89) to head (e77b447).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pinning/remote/client/client.go 0.00% 47 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
+ Coverage   60.34%   60.44%   +0.10%     
==========================================
  Files         244      244              
  Lines       31029    31027       -2     
==========================================
+ Hits        18723    18753      +30     
+ Misses      10634    10606      -28     
+ Partials     1672     1668       -4     
Files with missing lines Coverage Δ
pinning/remote/client/client.go 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

@gammazero gammazero changed the title Refactor remote pinning Ls to take a results channel instead of returning one Refactor remote pinning Ls to take results channel instead of returning one Dec 3, 2024
@lidel lidel changed the title Refactor remote pinning Ls to take results channel instead of returning one refactor(remote/pinning): Ls to take results channel instead of returning one Dec 3, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'm merging and bubbling up to ipfs/kubo#10527, will include this in Kubo 0.33.0-rc1

CHANGELOG.md Outdated Show resolved Hide resolved
@lidel lidel merged commit 3a3e8af into main Dec 3, 2024
12 checks passed
lidel added a commit to ipfs/kubo that referenced this pull request Dec 3, 2024
lidel pushed a commit to ipfs/kubo that referenced this pull request Dec 3, 2024
@lidel lidel deleted the new-ls branch December 3, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants