-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(remote/pinning): Ls
to take results channel instead of returning one
#738
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 60.34% 60.44% +0.10%
==========================================
Files 244 244
Lines 31029 31027 -2
==========================================
+ Hits 18723 18753 +30
+ Misses 10634 10606 -28
+ Partials 1672 1668 -4
|
Ls
to take a results channel instead of returning oneLs
to take results channel instead of returning one
Ls
to take results channel instead of returning oneLs
to take results channel instead of returning one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I'm merging and bubbling up to ipfs/kubo#10527, will include this in Kubo 0.33.0-rc1
This PR creates a new client
Ls
API that takes a write-only results channel instead of returns one. This is needed by ipfs/kubo#10527The original
Ls
behavior is implemented by theGoLs
function, which creates the channels, starts the goroutine that callsLs
, and returns the channels to the caller.