Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not send cancel message to peer that sent block #784

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gammazero
Copy link
Contributor

The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block.

Closes #694

The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block.

Closes #694
@gammazero gammazero requested a review from a team as a code owner January 8, 2025 19:10
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.50%. Comparing base (1097a4b) to head (5d46316).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   60.51%   60.50%   -0.02%     
==========================================
  Files         245      245              
  Lines       31133    31134       +1     
==========================================
- Hits        18841    18837       -4     
- Misses      10615    10619       +4     
- Partials     1677     1678       +1     
Files with missing lines Coverage Δ
bitswap/client/internal/peermanager/peermanager.go 91.85% <100.00%> (ø)
...wap/client/internal/peermanager/peerwantmanager.go 88.54% <100.00%> (+0.03%) ⬆️
bitswap/client/internal/session/session.go 90.18% <ø> (ø)
...p/client/internal/sessionmanager/sessionmanager.go 94.73% <100.00%> (-1.06%) ⬇️

... and 7 files with indirect coverage changes

@gammazero gammazero changed the title do not send CANCEL to peer we got block from do not send cancel message to peer that sent block Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitswap: Don't send CANCEL to peer we got block from
1 participant