-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ipfs-http-client -> kubo-rpc-client #9331
Conversation
Co-authored-by: Steve Loeppky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SgtPooki, in general avoid "HTTP API" (as we want Gateway to be that) and use "HTTP RPC" or even "HTTP RPC at /api/v0
" to remove ambiguity 🙏
@SgtPooki : I see I'm a requested reviewer. I don't know if I can get to it this week. Lets incorporate Lidel's feedback and then I think we'll call that good enough. |
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
@lidel ping |
addressed comments. need another review
Tracking issue: ipfs/js-kubo-rpc-client#35
Parent issue: ipfs/js-kubo-rpc-client#6
Originating issue: #9125
This PR is intended to update the docs in ipfs/kubo so that users will be pointed to
kubo-rpc-client
instead ofipfs-http-client
when using Javascript/TypeScript to talk to Kubo.I noticed a lack in discussion about programmatic/api usage, so I modified more than may be expected, but I think it should be a significant improvement.
Keeping the list of http-clients up to date now involves only updating a single file in this repo. LMK if this is not desireable.
For other docs updates, follow ipfs/js-kubo-rpc-client#6
fixes ipfs/js-kubo-rpc-client#35
Things for reviewers to check: