feat: opt-in WithShortForgeAddrs(true|false) to produce /dnsX addrs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests guarding implicit default, and explicit user preference
lidel
commented
Jan 15, 2025
lidel
commented
Jan 21, 2025
There was a problem hiding this comment.
thank you for fixing tests @guillaumemichel
merging – we can discuss switching default, but should be good enough for now
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 22, 2025
updates to p2p-forge/client with fix from ipshipyard/p2p-forge#42 we also add AutoTLS.ShortAddrs flag and enable it by default to benefit from shorter addrs discusses in ipshipyard/p2p-forge#40
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 22, 2025
* fix(autotls): renewal and AutoTLS.ShortAddrs updates to p2p-forge/client with fix from ipshipyard/p2p-forge#42 we also add AutoTLS.ShortAddrs flag and enable it by default to benefit from shorter addrs discusses in ipshipyard/p2p-forge#40 * test: fix flaky NewRandPort reducing chance of bind: address already in use
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 22, 2025
* fix(autotls): renewal and AutoTLS.ShortAddrs updates to p2p-forge/client with fix from ipshipyard/p2p-forge#42 we also add AutoTLS.ShortAddrs flag and enable it by default to benefit from shorter addrs discusses in ipshipyard/p2p-forge#40 * test: fix flaky NewRandPort reducing chance of bind: address already in use (cherry picked from commit 256a739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #34 by @guillaumemichel but in local branch allowing for commits from me.
client.WithShortForgeAddrscontrols if final addresses produced by p2p-forge addr factory are short and start with/dnsXor are longer and the DNS name is fully resolved into multiaddr starting with/ipXand containing an explicit/snicomponent.Using
/dnsXmay be beneficial when interop with older libp2p clients isrequired, or when shorter addresses are preferred.
TLDR
WithShortForgeAddrs(true):/dnsX/<escaped-ip>.<peer-id>.<forge-domain>/tcp/<port>/tls/wsWithShortForgeAddrs(false):/ipX/<ip>/tcp/<port>/tls/sni/<escaped-ip>.<peer-id>.<forge-domain>/ws/ipX..as before)