Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_prg update PR series: 5. CLI changes #37

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

leoisl
Copy link
Collaborator

@leoisl leoisl commented Apr 19, 2022

  1. Adds --suffix parameter to make_prg from_msa. This is in general useful, but it is actually required to use make_prg in a snakemake pipeline. The main issue I faced is that a snakemake pipeline is creating a dir of MSAs to be fed into make_prg from_msa, but currently just using the --input parameter and giving a dir as input tries to build a PRG from every file in the dir, including the .snakemake_timestamp file. This allows us to further filter out which files we want to build a PRG from;
  2. Adds --long-deletion-threshold parameter to make_prg update. Current make_prg update implementation has issues dealing with long deletions, this parameter controls the size of the deletion we consider and ignore.

@leoisl leoisl requested review from mbhall88 and bricoletc April 19, 2022 12:59
make_prg/subcommands/from_msa.py Show resolved Hide resolved
make_prg/subcommands/update.py Outdated Show resolved Hide resolved
make_prg/subcommands/update.py Show resolved Hide resolved
make_prg/update/denovo_variants.py Show resolved Hide resolved
@mbhall88
Copy link
Member

mbhall88 commented Jul 4, 2022

@leoisl just wondering if you have an ETA on this (and therefore v0.3)? I am working on drprg again which relies on make_prg, so it would be nice to use the latest conda version rather than the binary from your fork.

@leoisl
Copy link
Collaborator Author

leoisl commented Nov 22, 2022

I logged the last remaining comment as an issue and I am moving to submit more PRs so we can finally merge and release this

@leoisl leoisl merged commit 7e308c5 into iqbal-lab-org:dev Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants