Use plain libXaw instead of libXaw3d #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
libxaw
branch
4 times, most recently
from
68eaaa3 to
c84250a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llibXaw3d is basically unmaintained since years, and it is (IMO) only a question of time that it gets removed, as part of the general declination of X11.
Here, we patch out the use of Xaw3D. As x11iraf uses the LayoutWidget which is specific to libXaw3d, its sources are added. These files are copyrighted by MIT, which is already covered by our
LICENSESfile.This PR is not required to be merged now, it just lets us react to the moment when Xaw3D becomes unavailable on any supported platform.