Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling Empty Files Before Unmarshalling to Prevent Unmarshal Errors #163

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Handling Empty Files Before Unmarshalling to Prevent Unmarshal Errors #163

merged 3 commits into from
Feb 21, 2024

Conversation

so-sahu
Copy link
Contributor

@so-sahu so-sahu commented Feb 8, 2024

Fixes #155

@so-sahu so-sahu self-assigned this Feb 8, 2024
@so-sahu so-sahu requested a review from a team as a code owner February 8, 2024 07:00
@github-actions github-actions bot added bug Something isn't working size/XS labels Feb 8, 2024
lukas016
lukas016 reviewed Feb 8, 2024
View reviewed changes
pkg/host/store.go Outdated Show resolved Hide resolved
lukas016
lukas016 reviewed Feb 8, 2024
View reviewed changes
pkg/host/store.go Outdated Show resolved Hide resolved
@so-sahu so-sahu force-pushed the fix/handling-empty-file branch from 95cf614 to 897467f Compare February 14, 2024 09:05
lukas016
lukas016 requested changes Feb 14, 2024
View reviewed changes
pkg/host/store.go Outdated Show resolved Hide resolved
pkg/sync/sync.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/S and removed size/M labels Feb 15, 2024
@so-sahu so-sahu force-pushed the fix/handling-empty-file branch from 3a96e6a to ae8d431 Compare February 15, 2024 12:42
@so-sahu so-sahu requested a review from lukas016 February 15, 2024 12:44
lukas016
lukas016 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@so-sahu so-sahu requested review from hardikdr and a team February 16, 2024 09:34
@so-sahu so-sahu added the integration-tests to run integration tests label Feb 19, 2024
hardikdr
hardikdr approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !!
Let's keep an eye on how the locks during reads play out. If things get slow, we might want to adjust later.

@hardikdr hardikdr removed the request for review from lukasfrank February 21, 2024 15:16
@hardikdr hardikdr force-pushed the fix/handling-empty-file branch from ae8d431 to e2b686e Compare February 21, 2024 15:17
@hardikdr hardikdr merged commit 80ef3fb into main Feb 21, 2024
9 checks passed
@hardikdr hardikdr deleted the fix/handling-empty-file branch February 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank left review comments

@lukas016 lukas016 lukas016 approved these changes

@hardikdr hardikdr hardikdr approved these changes

Assignees

@so-sahu so-sahu

Labels
bug Something isn't working integration-tests to run integration tests server size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Empty Files Before Unmarshalling to Prevent Unmarshal Errors
4 participants
@so-sahu @lukasfrank @hardikdr @lukas016