Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-hide/unhide Annotations-DSaatz JuliaF9-Allows to enable and disable the syntax highlighting for code annotations #107

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feature-hide/unhide Annotations-DSaatz JuliaF9-Allows to enable and disable the syntax highlighting for code annotations #107

wants to merge 16 commits into from

Conversation

DSaatz
Copy link

@DSaatz DSaatz commented Dec 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • Tests are created and passing
  • Manual testing

Screenshots (if appropriate):

Types of changes

  • Pipeline changes
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the CONTRIBUTORS file.
  • I have updated the CHANGELOG.

DSaatz and others added 16 commits November 1, 2024 16:57
@DSaatz
Set-Up ToggleAction and needed services, added to plugin.xml and trie…
87b5083 
…d setting up UI (needs fixes), misses logic for toggeling
@DSaatz
Fixed issue with accessing ToggleState the wrong way
0013999
@DSaatz
Added Logger to ToggleAction for debugging and tried fixing the butto…
f0ee5d4 
…n for it
@DSaatz
Fix: Main Menu Button for Actions (right now only ToggleAction) has b…
00d3057 
…een added succesfully
@DSaatz
Removed previous changes that have been made to CodeAnnotationAnnotator
e52102f
@DSaatz
Made CodeAnnotationsSyntaxHighlighterFactory depend on toggle state, …
912e56c 
…current issue is that ToggleStateService is null at runtime (see error logs)
@DSaatz
Fix: fixed nullPointer at anything related to ToggleStateService and …
18badc9 
…added dependency of CodeAnnotationsSyntaxHighlighterFactory to state, need to implement a profile for no highlighting.
@DSaatz
Added NoOpSyntaxHighlighter, needs implementation. Inserted its usage…
bbed987 
… to CodeAnnotationsSyntaxHighlighterFactory and added refresh to ToggleStateService
@DSaatz
Implemented NoOpSyntaxHighlighter, refreshes are most likely missing …
ffdd6d5 
…and need to be implemented correctly
@JuliaF9
Added comments in ToggleAction.java
284a2f7
@DSaatz
Merge remote-tracking branch 'origin/hideSyntaxHighlighting' into hid…
49ee87b 
…eSyntaxHighlighting
@DSaatz
Toggling syntaxhighlighting possible but does only refresh to current…
d41c55c 
… state after IDE restart, added logging to console for debugging temporarily.
@DSaatz
migrated toggle settings to SettingsPageBuilder UI element and added …
d12b4ba 
…dialog that requires user to restart the IDE for the changes to take place, everything works
@DSaatz
disabled logging which was added for the testing of the disable-synta…
fc8cae6 
…xhighlighting feature
@DSaatz
Merge branch 'isselab:main' into hideSyntaxHighlighting
1a5f986
@DSaatz
fixed text in SettingsPageBuilder because it was the other way around
d8008eb
@DSaatz
Copy link
Author

DSaatz commented Dec 8, 2024

If anyhting else has to be done to fullfill the requirments for the feature and the pull request, please tell @JuliaF9 and me and we will go about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DSaatz @JuliaF9