Allow specifying an order of Qt versions to consider #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify code by using foreach instead of while loop.
rhaschke
force-pushed
the
qt6-compat
branch
2 times, most recently
from
f3d620d to
0920ba4
Compare
|
I also added Qt6 to CI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generalized the logic further to allow for specifying a list of Qt versions to consider (via cmake variable
RVIZ_QT_VERSIONS, which defaults to "5;6"). You can set the variable to "6;5" to prioritize Qt 6 over Qt 5.With this change, your PR is ready to merge I think.