Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated spid-cie-oidc-django version #23

Merged
merged 27 commits into from
Oct 25, 2023
Merged

Conversation

rglauco
Copy link
Collaborator

@rglauco rglauco commented Oct 12, 2023

fix: pinned python docker image to 3.11-slim
fix: pinned design-django-theme to 1.4.8
fix: SPID attributes aligned to the specs v.1.3
fix: CIE attributes aligned to the specs
chore: added complete SPID user claims request
feat: added alg/enc algorithm claims for idtoken and userinfo

@peppelinux
Copy link
Member

@rglauco did you have tested this upgrade with the current spid-cie-oidc-django release you mentioned?

@rglauco
Copy link
Collaborator Author

rglauco commented Oct 12, 2023

Yes, i've tested the updated Federation Entity and by now i can register RP entity and access to the login page.

@peppelinux peppelinux requested a review from mmariuzzo October 22, 2023 14:19
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (88a0733) 91.19% compared to head (29d23c5) 91.11%.
Report is 2 commits behind head on main.

❗ Current head 29d23c5 differs from pull request most recent head b1f5435. Consider uploading reports for the commit b1f5435 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #23      +/-   ##
============================================
- Coverage     91.19%   91.11%   -0.09%     
- Complexity      761      774      +13     
============================================
  Files            47       47              
  Lines          2316     2340      +24     
  Branches        300      300              
============================================
+ Hits           2112     2132      +20     
+ Misses          112      111       -1     
- Partials         92       97       +5     
Files Coverage Δ
.../it/spid/cie/oidc/handler/RelyingPartyHandler.java 85.12% <100.00%> (+0.63%) ⬆️
...in/java/it/spid/cie/oidc/schemas/CIEClaimItem.java 100.00% <100.00%> (ø)
.../main/java/it/spid/cie/oidc/schemas/ClaimItem.java 100.00% <ø> (ø)
...n/java/it/spid/cie/oidc/schemas/SPIDClaimItem.java 100.00% <100.00%> (ø)
...a/it/spid/cie/oidc/config/RelyingPartyOptions.java 94.62% <86.11%> (-1.53%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rglauco rglauco merged commit 3dc796f into italia:main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants