Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to std::span -based API, avoid *raw* pointer(s) #23

Merged
merged 12 commits into from
Dec 3, 2023
Merged

Port to std::span -based API, avoid *raw* pointer(s) #23

merged 12 commits into from
Dec 3, 2023

Conversation

itzmeanjan
Copy link
Owner

@itzmeanjan itzmeanjan commented Dec 1, 2023 •
edited
Loading

  • Avoid raw pointer+length based interfaces, instead rewrite using statically typed std::span based interfaces

Note

Read more about span @ https://en.cppreference.com/w/cpp/container/span

  • Update usage examples, benchmark results etc.

@itzmeanjan itzmeanjan self-assigned this Dec 1, 2023
@itzmeanjan
pin sha3 to latest commit
2502753 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
start using std::span in interfaces of all underlying functions
9c86aa4 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
port dilithium digital signature scheme to using std::span based inte…
6821715 
…rface

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update ColumnLimit of source formatter configuration
fc8552d 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update tests to use new std::span based interface
f69b8bb 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
fix subspan related issues in Dilithium implementation
89f403f 
These issues were caught when compiling test suite

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
rewrite benchmark functions using std::span based API
46e6730 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
run CI tests also on macos-latest
7541518 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan itzmeanjan merged commit 3fe6ab6 into master Dec 3, 2023
2 checks passed
@itzmeanjan itzmeanjan deleted the use-std-span branch December 3, 2023 16:37
@itzmeanjan
Copy link
Owner Author

This patch reduces the performance of all functions (keygen, sign and verify) by an average of ~8%.

Screenshot from 2023-12-03 20-52-09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@itzmeanjan itzmeanjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itzmeanjan