Way of the Wind! Light and Shadow! Dual Moves! Game Settings! More! Version bump time? #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lib.rs compiler warning.
…m properly in Settings.
…re Wind Moves for now
onitamasuperfan
force-pushed
the
master
branch
from
59ea806 to
4ce39aa
Compare
…xtra move or pass.
onitamasuperfan
changed the title
|
Ok this now addresses everything in #23 Phase 1. Anything I'd still like to work on is mostly cosmetic or part of Light & Shadow Phase 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok here it is. The big one!
This has taken a long time, but Dual Move cards and the Way of the Wind expansion are implemented. In addition, I've centralized GameSettings into a serializable object, centralized other common functions, refactored some code, and made improvements to the Settings and Home pages. I've tried to build with an eye towards future improvements and additions like Light and Shadow, which I'd love to work on next once this is merged.
Considering I was learning Rust, WASM and React as I went, I think I did pretty good.
One note, I accidentally removed the "Played" tag on the spare card for narrow screens. I'll try to fix it later.
Resolves #19
Resolves #16
Significant work towards #23
Thanks for structuring the original game and AI agents, @jackadamson . Hopefully all this work won't go to waste. I look forward to reading your thoughts and even more to seeing this go live on the main server.