-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
8 changed files
with
2,341 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Lint changes | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - uses: pnpm/action-setup@v2 | ||
| with: | ||
| version: 8.6.0 | ||
|
|
||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| cache: pnpm | ||
|
|
||
| - run: pnpm install | ||
|
|
||
| - name: Run ESLint on changed files | ||
| uses: tj-actions/eslint-changed-files@v24 | ||
| with: | ||
| config_path: eslint.config.js | ||
| file_extensions: | | ||
| **/*.ts | ||
| **/*.js | ||
| **/*.svelte | ||
| **/*.composition | ||
| **/*.html | ||
| **/*.markdown | ||
| **/*.json | ||
| **/*.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| // To run automatically on commit, add `simple-git-hooks` and `lint-staged` then run `npx simple-git-hooks` once. After that all commits will be linted. | ||
|
|
||
| // @ts-check | ||
| import { antfu } from '@antfu/eslint-config' | ||
| import jsEslintPlugin from '@eslint/js' | ||
| import tsEslintPlugin from '@typescript-eslint/eslint-plugin' | ||
| import svelteStylistic from 'eslint-plugin-svelte-stylistic' | ||
|
|
||
| // Inspect: npx @eslint/config-inspector | ||
| export default antfu( | ||
| { | ||
| ignores: [ | ||
| '**/.svelte-kit**', | ||
| '**/functions/lib/**', | ||
| '.eslintcache', | ||
| 'packages/scripts/import/old**', | ||
| '**/route/kitbook/**', | ||
| '**/locales/**', | ||
| 'supabase/functions/**', | ||
| ], | ||
| stylistic: { | ||
| overrides: { | ||
| 'style/brace-style': ['error', '1tbs', { allowSingleLine: true }], | ||
| 'antfu/if-newline': 'off', | ||
| 'curly': 'off', | ||
| }, | ||
| }, | ||
| svelte: true, | ||
| }, | ||
| { | ||
| name: 'jacob/svelte/stylistic', | ||
| files: ['**/*.svelte', '**/*.composition'], | ||
| plugins: { | ||
| 'svelte-stylistic': svelteStylistic, | ||
| }, | ||
| rules: { | ||
| 'svelte-stylistic/brackets-same-line': 'error', | ||
| 'svelte-stylistic/consistent-attribute-lines': 'error', | ||
| }, | ||
| }, | ||
| { | ||
| name: 'jacob/test/rules', | ||
| files: ['**/*.test.ts'], | ||
| rules: { | ||
| 'test/consistent-test-it': ['error', { fn: 'test' }], | ||
| 'test/no-commented-out-tests': 'error', | ||
| 'test/no-disabled-tests': 'error', | ||
| 'test/consistent-test-filename': 'error', | ||
| 'test/expect-expect': 'error', | ||
| 'test/no-alias-methods': 'error', | ||
| 'test/no-conditional-expect': 'error', | ||
| 'test/no-conditional-in-test': 'error', | ||
| 'test/no-conditional-tests': 'error', | ||
| 'test/no-duplicate-hooks': 'error', | ||
| 'test/no-focused-tests': 'error', | ||
| 'test/no-standalone-expect': 'error', | ||
| 'test/no-test-return-statement': 'error', | ||
| 'test/prefer-comparison-matcher': 'error', | ||
| 'test/prefer-hooks-on-top': 'error', | ||
| 'test/prefer-spy-on': 'error', | ||
| 'test/prefer-to-be-falsy': 'error', | ||
| 'test/prefer-to-be-truthy': 'error', | ||
| 'test/prefer-to-contain': 'error', | ||
| 'test/prefer-to-have-length': 'error', | ||
| 'test/valid-describe-callback': 'error', | ||
| 'test/valid-expect': 'error', | ||
| }, | ||
| }, | ||
| { | ||
| name: 'jacob/settings', | ||
| files: ['.vscode/*.json'], | ||
| rules: { | ||
| 'jsonc/comma-dangle': ['error', 'always-multiline'], | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ld/script-exceptions', | ||
| files: ['packages/{scripts,functions}/**'], | ||
| rules: { | ||
| 'no-console': 'off', | ||
| 'ts/no-unused-vars': 'off', | ||
| 'ts/no-var-requires': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ld/intercontinental-dictionaries-series', | ||
| files: ['**/ids-import/**'], | ||
| rules: { | ||
| 'ts/no-unused-vars': 'off', | ||
| 'no-undef': 'off', | ||
| }, | ||
| }, | ||
| ).overrides({ | ||
| 'antfu/typescript/rules': { | ||
| files: ['**/*.svelte', '**/*.composition'], | ||
| rules: { | ||
| ...jsEslintPlugin.configs.recommended.rules, | ||
| // ...tsEslintPlugin.configs.recommended.rules, // cause the rest to break | ||
| ...tsEslintPlugin.configs.stylistic.rules, | ||
|
|
||
| 'prefer-destructuring': 'error', | ||
| 'no-constant-binary-expression': 'error', | ||
| 'ts/default-param-last': 'error', | ||
| 'require-await': 'error', | ||
| 'prefer-object-spread': 'error', | ||
| 'no-useless-concat': 'error', | ||
| 'no-else-return': 'error', | ||
| 'no-console': ['error', { allow: ['warn', 'error', 'info', 'time', 'timeEnd'] }], | ||
| 'require-atomic-updates': 'error', | ||
| 'style/quotes': ['error', 'single', { | ||
| allowTemplateLiterals: true, | ||
| avoidEscape: true, | ||
| }], | ||
| 'ts/no-unused-vars': ['warn', { | ||
| argsIgnorePattern: '^_', | ||
| caughtErrors: 'none', | ||
| ignoreRestSiblings: true, | ||
| // vars: 'all', // is this helpful? | ||
| varsIgnorePattern: '^\\$\\$Props$', | ||
| }], | ||
|
|
||
| 'ts/no-explicit-any': 'warn', | ||
| 'prefer-named-capture-group': 'warn', | ||
|
|
||
| 'no-undef': 'off', | ||
| 'no-unused-vars': 'off', | ||
| 'no-alert': 'off', | ||
| 'ts/ban-ts-comment': 'off', | ||
| 'ts/sort-type-constituents': 'off', // prefer logical rather than alphabetical sorting | ||
| }, | ||
| }, | ||
| 'antfu/svelte/rules': { | ||
| files: ['**/*.composition'], | ||
| rules: { | ||
| 'svelte/valid-compile': ['error', { ignoreWarnings: true }], // throws error on a11y issues | ||
| 'svelte/no-dom-manipulating': 'error', | ||
| 'svelte/no-store-async': 'error', // causes issues with auto-unsubscribing features | ||
| 'svelte/require-store-reactive-access': 'error', | ||
| 'svelte/require-event-dispatcher-types': 'error', | ||
| 'svelte/button-has-type': 'error', | ||
| 'svelte/no-extra-reactive-curlies': 'error', | ||
| 'svelte/mustache-spacing': 'error', | ||
| 'svelte/html-closing-bracket-spacing': 'error', | ||
| 'svelte/no-reactive-reassign': ['warn', { props: false }], | ||
|
|
||
| 'svelte/html-quotes': 'off', // should it enforce double quotes? | ||
| 'svelte/no-at-html-tags': 'off', | ||
| 'no-unused-expressions': 'off', | ||
| 'no-inner-declarations': 'off', | ||
| 'style/space-infix-ops': 'off', | ||
| 'no-undef-init': 'off', | ||
| 'no-self-assign': 'off', | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| // learn more | ||
| // https://github.com/AndreaPontrandolfo/sheriff | ||
| // https://github.com/enso-org/enso/blob/b2c1f97437870fa7b7a4d7c2d3630e2d2bd6fc2c/app/ide-desktop/eslint.config.js | ||
| // https://github.com/azat-io/eslint-config/blob/044959d8fef2acff50e252b8a238be933cd38eea/base/index.ts | ||
| // https://github.com/darkobits/eslint-plugin/blob/f55a64dc9038148f3227cda7ae4543dffcb0b14e/src/config-sets/ts | ||
| // https://github.com/azat-io/eslint-config/blob/044959d8fef2acff50e252b8a238be933cd38eea/react/index.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.