Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for raw html warnings #787

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 23, 2024

Which problem is this PR solving?

  • The latest version of Hugo does not render some parts of the content represented via raw HTML, it instead logs these warnings: WARN Raw HTML omitted while rendering .../content/docs/1.63/operator.md"; see https://gohugo.io/getting-started/configuration-markup/#rendererunsafe. You can suppress this warning by adding the following to your site configuration: ignoreLogs = ['warning-goldmark-raw-html']

Description of the changes

  • Following this blog post, add a rawhtml shortcode and wrap <img> tags with it.
  • Remove <!-- ... --> comments in the old operator.md files, but in the next-release/operator.md replace them with go template comments

How was this change tested?

  • the image was missing in the previous iterations, now it shows on the page image
  • make build no longer shows raw html warnings

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 57a3d69
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/674277181c84ba00080c1d82
😎 Deploy Preview https://deploy-preview-787--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit edb1c09 into jaegertracing:main Nov 24, 2024
10 checks passed
@yurishkuro yurishkuro deleted the fix-raw-html branch November 24, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant