Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade antd to v5.23.0 from v5.21.3 #2579

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

manzil-infinity180
Copy link
Contributor

@manzil-infinity180 manzil-infinity180 commented Jan 10, 2025

Which problem is this PR solving?

Issue #2576

Description of the changes

How was this change tested?

  • automated testing
  • some changes to snapshot (npm run test-ci -- -u)

Checklist

Signed-off-by: Rahul Vishwakarma <[email protected]>
Signed-off-by: Rahul Vishwakarma <[email protected]>
Signed-off-by: Rahul Vishwakarma <[email protected]>
@manzil-infinity180 manzil-infinity180 requested a review from a team as a code owner January 10, 2025 07:52
@manzil-infinity180 manzil-infinity180 requested review from pavolloffay and removed request for a team January 10, 2025 07:52
@yurishkuro
Copy link
Member

this adds a lot of new dependencies in the form rc-***, do you know what they are? Are there some docs in AntD about adding them?

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (7907434) to head (7308b2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7731     7731           
  Branches     2010     2010           
=======================================
  Hits         7471     7471           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Jan 10, 2025
@manzil-infinity180
Copy link
Contributor Author

manzil-infinity180 commented Jan 10, 2025

@yurishkuro see answer here i opened github discussion
ant-design/ant-design#52358

@yurishkuro yurishkuro enabled auto-merge (squash) January 10, 2025 18:14
@yurishkuro
Copy link
Member

thanks for your contribution!

@yurishkuro yurishkuro merged commit 2a0a8d3 into jaegertracing:main Jan 10, 2025
8 of 9 checks passed
@yurishkuro
Copy link
Member

@manzil-infinity180 how exactly did you do the upgrade? Renovate bot is still trying to apply it and failing #2516

@manzil-infinity180
Copy link
Contributor Author

@yurishkuro I just removed/uninstall the @ctrl/tinycolor module and re-install the antd to latest version as per this docs

@yurishkuro
Copy link
Member

can you look into why #2516 is failing?

@manzil-infinity180
Copy link
Contributor Author

And test is also failing for that module

Cannot find module '@ctrl/tinycolor' from '../../node_modules/@ant-design/compatible/lib/theme/genColorMapToken.js'

Require stack:
  /home/runner/work/jaeger-ui/jaeger-ui/node_modules/@ant-design/compatible/lib/theme/genColorMapToken.js
  /home/runner/work/jaeger-ui/jaeger-ui/node_modules/@ant-design/compatible/lib/theme/default.js
  /home/runner/work/jaeger-ui/jaeger-ui/node_modules/@ant-design/compatible/lib/theme/index.js
  /home/runner/work/jaeger-ui/jaeger-ui/node_modules/@ant-design/compatible/lib/index.js
  src/components/App/index.jsx
  src/components/App/index.test.js

@manzil-infinity180
Copy link
Contributor Author

It seems that Renovate is still attempting to apply an upgrade for @ctrl/tinycolor, even though the dependency has already been removed or replaced with fast color in the latest versions of some libraries. The error likely stems from:

  • An indirect dependency still referencing @ctrl/tinycolor.
  • An outdated package-lock.json or yarn.lock causing Renovate to think the dependency is still active.

yurishkuro added a commit that referenced this pull request Jan 11, 2025
This reverts commit 2a0a8d3.

Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro added a commit that referenced this pull request Jan 11, 2025
Renovate bot is unhappy with that PR, it looks like it was incomplete
and more changes were needed:
#2516

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
Copy link
Member

I reverted this. I recommend doing the upgrade by taking the Renovate PR and applying whichever additional changes to the code are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants