-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade antd to v5.23.0 from v5.21.3 #2579
Upgrade antd to v5.23.0 from v5.21.3 #2579
Conversation
Signed-off-by: Rahul Vishwakarma <[email protected]>
Signed-off-by: Rahul Vishwakarma <[email protected]>
Signed-off-by: Rahul Vishwakarma <[email protected]>
this adds a lot of new dependencies in the form |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 255 255
Lines 7731 7731
Branches 2010 2010
=======================================
Hits 7471 7471
Misses 260 260 ☔ View full report in Codecov by Sentry. |
@yurishkuro see answer here i opened github discussion |
thanks for your contribution! |
@manzil-infinity180 how exactly did you do the upgrade? Renovate bot is still trying to apply it and failing #2516 |
@yurishkuro I just removed/uninstall the @ctrl/tinycolor module and re-install the antd to latest version as per this docs |
can you look into why #2516 is failing? |
And test is also failing for that module Cannot find module '@ctrl/tinycolor' from '../../node_modules/@ant-design/compatible/lib/theme/genColorMapToken.js'
|
It seems that Renovate is still attempting to apply an upgrade for
|
This reverts commit 2a0a8d3. Signed-off-by: Yuri Shkuro <[email protected]>
Renovate bot is unhappy with that PR, it looks like it was incomplete and more changes were needed: #2516 Signed-off-by: Yuri Shkuro <[email protected]>
I reverted this. I recommend doing the upgrade by taking the Renovate PR and applying whichever additional changes to the code are needed. |
Which problem is this PR solving?
Issue #2576
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test