Remove default props

.gitignore

@@ -7,7 +7,6 @@ node_modules
 
 # production
 build
-
 # reports
 coverage
 .nyc_output

packages/jaeger-ui/src/components/SearchTracePage/SearchForm.jsx

@@ -262,12 +262,12 @@ export class SearchFormImpl extends React.PureComponent {
   render() {
     const {
       handleSubmit,
-      invalid,
+      invalid = false,
       searchMaxLookback,
-      selectedLookback,
-      selectedService = '-',
-      services,
-      submitting: disabled,
+      selectedLookback = null,
+      selectedService = null,
+      services = [],
+      submitting = false,
     } = this.props;
     const selectedServicePayload = services.find(s => s.name === selectedService);
     const opsForSvc = (selectedServicePayload && selectedServicePayload.operations) || [];
@@ -555,14 +555,6 @@ SearchFormImpl.propTypes = {
   selectedLookback: PropTypes.string,
 };
 
-SearchFormImpl.defaultProps = {
-  invalid: false,
-  services: [],
-  submitting: false,
-  selectedService: null,
-  selectedLookback: null,
-};
-
 export const searchSideBarFormSelector = formValueSelector('searchSideBar');
 
 export function mapStateToProps(state) {

packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ScatterPlot.jsx

@@ -23,9 +23,11 @@ import { ONE_MILLISECOND, formatDuration } from '../../../utils/date';
 import 'react-vis/dist/style.css';
 import './ScatterPlot.css';
 
-export default function ScatterPlot(props) {
-  const { data, onValueClick, calculateContainerWidth } = props;
-
+export default function ScatterPlot({
+  data,
+  onValueClick,
+  calculateContainerWidth = container => container.clientWidth,
+}) {
   const containerRef = useRef(null);
   const [containerWidth, setContainerWidth] = useState(0);
 
@@ -103,8 +105,3 @@ ScatterPlot.propTypes = {
   onValueClick: PropTypes.func.isRequired,
   calculateContainerWidth: PropTypes.func,
 };
-
-ScatterPlot.defaultProps = {
-  // JSDOM does not, as of 2023, have a layout engine, so allow tests to supply a mock width as a workaround.
-  calculateContainerWidth: container => container.clientWidth,
-};

packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.tsx

@@ -75,8 +75,15 @@ export function Attrs(props: AttrsProps) {
   );
 }
 
-export default function TraceHeader(props: Props) {
-  const { duration, error, startTime, state, traceID, totalSpans, traceName } = props;
+export default function TraceHeader({
+  duration,
+  error = undefined,
+  startTime,
+  state,
+  traceID,
+  totalSpans,
+  traceName,
+}: Props) {
   const AttrsComponent = state === fetchedState.DONE ? Attrs : EmptyAttrs;
 
   return (
@@ -101,7 +108,3 @@ export default function TraceHeader(props: Props) {
     </div>
   );
 }
-
-TraceHeader.defaultProps = {
-  error: undefined,
-};

packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/AccordianKeyValues.tsx

@@ -35,8 +35,7 @@ type AccordianKeyValuesProps = {
 };
 
 // export for tests
-export function KeyValuesSummary(props: { data?: KeyValuePair[] }) {
-  const { data } = props;
+export function KeyValuesSummary({ data = null }: { data?: KeyValuePair[] | null }) {
   if (!Array.isArray(data) || !data.length) {
     return null;
   }
@@ -55,12 +54,16 @@ export function KeyValuesSummary(props: { data?: KeyValuePair[] }) {
   );
 }
 
-KeyValuesSummary.defaultProps = {
-  data: null,
-};
-
-export default function AccordianKeyValues(props: AccordianKeyValuesProps) {
-  const { className, data, highContrast, interactive, isOpen, label, linksGetter, onToggle } = props;
+export default function AccordianKeyValues({
+  className = null,
+  data,
+  highContrast = false,
+  interactive = true,
+  isOpen,
+  label,
+  linksGetter,
+  onToggle = null,
+}: AccordianKeyValuesProps) {
   const isEmpty = !Array.isArray(data) || !data.length;
   const iconCls = cx('u-align-icon', { 'AccordianKeyValues--emptyIcon': isEmpty });
   let arrow: React.ReactNode | null = null;
@@ -94,10 +97,3 @@ export default function AccordianKeyValues(props: AccordianKeyValuesProps) {
     </div>
   );
 }
-
-AccordianKeyValues.defaultProps = {
-  className: null,
-  highContrast: false,
-  interactive: true,
-  onToggle: null,
-};