Switch to alternative lavalink youtube source #1604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeric-morency
commented
Jun 29, 2024
| <version>1.0.4</version> | ||
| <groupId>dev.lavalink.youtube</groupId> | ||
| <artifactId>v2</artifactId> | ||
| <version>b2c8c070cdc4caa1fa93d0d7ac3f9d468bfa27a8-SNAPSHOT</version> |
There was a problem hiding this comment.
For reference, I found this version in an issue comment in their repo
Latest tag is 1.3.0, I can switch from the commit SNAPSHOT version to 1.3.0 if you prefer (even though it doesn't have the cookies fix), I didn't test it however as I didn't initially plan to open a PR with it.
|
Is it possible to have a release with this changes pls ? |
|
I tested this and still get the same login error |
Considering this, I'll close this PR and re-open one if the alternate Youtube source tags a release with a full fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
Replace the current Youtube player dependecy with lavalink's alternative Youtube source (https://github.com/lavalink-devs/youtube-source)
Purpose
This fixed the "sign in" issue for my local bot (single Discord server, bot being hosted on a VM on my LAN, so definitely not running at scale). YMMV I would guess, if it's a Youtube denylist thing then it's just a matter of time before my IP is re-denylisted, but we've been running with that for the past week and a half and haven't had issues yet.
Relevant Issue(s)
This PR closes issue #1588