[ci] move shellcheck to pre-commit, use shellcheck-py #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
shellcheck
intopre-commit
checks, and uses https://github.com/shellcheck-py/shellcheck-py so it can be installed automatically from PyPI (instead of needing to be installed separately before running linting).This also uses
pre-commit
's mechanism for detecting files, and doesn't rely on file extensions. So it caught a few other uncaughtshellcheck
things in other files 🙌🏻