Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] move shellcheck to pre-commit, use shellcheck-py #249

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

jameslamb
Copy link
Owner

Moves shellcheck into pre-commit checks, and uses https://github.com/shellcheck-py/shellcheck-py so it can be installed automatically from PyPI (instead of needing to be installed separately before running linting).

This also uses pre-commit's mechanism for detecting files, and doesn't rely on file extensions. So it caught a few other uncaught shellcheck things in other files 🙌🏻

@jameslamb jameslamb added the maintenance Not a bug or feature label May 27, 2024
@jameslamb jameslamb merged commit d6a80f9 into main May 27, 2024
21 checks passed
@jameslamb jameslamb deleted the ci/shellcheck branch May 27, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant