Skip to content

Commit

Permalink
Set timeout for artifact building and "run tests" steps
Browse files Browse the repository at this point in the history
Also, use a conditional expression in the continuous workflow to control concurrent runs. We don't want to cancel runs on multiple pushes to main or release branch.

PiperOrigin-RevId: 716780290
  • Loading branch information
nitins17 authored and Google-ML-Automation committed Jan 17, 2025
1 parent 12b59f8 commit 12beb00
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/build_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
with:
halt-dispatch-input: ${{ inputs.halt-for-connection }}
- name: Build ${{ inputs.artifact }}
timeout-minutes: 30
run: ./ci/build_artifacts.sh "${{ inputs.artifact }}"
- name: Upload artifacts to a GCS bucket (non-Windows runs)
if: >-
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pytest_cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,5 @@ jobs:
with:
halt-dispatch-input: ${{ inputs.halt-for-connection }}
- name: Run Pytest CPU tests
timeout-minutes: 60
run: ./ci/run_pytest_cpu.sh
1 change: 1 addition & 0 deletions .github/workflows/pytest_cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,5 @@ jobs:
with:
halt-dispatch-input: ${{ inputs.halt-for-connection }}
- name: Run Pytest CUDA tests
timeout-minutes: 60
run: ./ci/run_pytest_cuda.sh
2 changes: 1 addition & 1 deletion .github/workflows/wheel_tests_continuous.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
cancel-in-progress: ${{ !contains(github.ref, 'release/') && github.ref != 'main' }}

jobs:
build-jaxlib-artifact:
Expand Down

0 comments on commit 12beb00

Please sign in to comment.